feat(ske): respect KUBECONFIG environment variable (#875)

[KevinGimbel]

Description

relates to #875

Checklist

• Issue was linked above
• Code format was applied: make fmt
• Examples were added / adjusted (see e.g. here)
• Docs are up-to-date: make generate-docs (will be checked by CI)
• Unit tests got implemented or updated
• Unit tests are passing: make test (will be checked by CI)
• No linter issues: make lint (will be checked by CI)

[github-actions]

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

[hinricht]

Interested in this feature

[KevinGimbel]

Is there anything else I can do to push this PR? Any change requests? :)

[rubenhoenle]

Hey @KevinGimbel,

first of all thanks for your contribution!

I think the docs will also need some adjustments so other users know how this new cool feature works.

• stackit-cli/internal/cmd/ske/kubeconfig/create/create.go

  Line 51 in 2446141

  "You can override this behavior by specifying a custom filepath with the --filepath flag.\n",

  I would suggest to change this to something like You can override this behavior by specifying a custom filepath using the --filepath flag or by setting the KUBECONFIG env variable (fallback).

• stackit-cli/internal/cmd/ske/kubeconfig/create/create.go

  Line 173 in 2446141

  cmd.Flags().String(filepathFlag, "", "Path to create the kubeconfig file. By default, the kubeconfig is created as 'config' in the .kube folder, in the user's home directory.")

  Suggestion: Path to create the kubeconfig file. Will fall back to KUBECONFIG env variable if not set. By default in case both aren't set, the kubeconfig is created as 'config' in the .kube folder, in the user's home directory.

Make sure to run make generate-docs after adjusting this :)

[rubenhoenle]

Linter failed in the CI pipeline, please check this. You can run make lint on your local machine to get the same output.

[rubenhoenle]

Tested it manually, looks good so far :)

[KevinGimbel]

@rubenhoenle thanks for the feedback! I made the changes and ran the linting again and fixed the issue it showed.

[rubenhoenle]

@KevinGimbel you will need to update your branch, e.g. by rebasing so we're able to merge this.

[rubenhoenle]

Consider enabling edits by maintainers on your next PR, then we should be able to do the rebase for you :)

[KevinGimbel]

Sorry, didn't know this was an option!