-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Remove refresh_token grant type from automated refresh #3706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
69e7704 to
0e1474e
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
Not stale |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
Not stale |
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
0e1474e to
7bd5786
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
SA key flow is designed for machine 2 machine communication, so using
refresh_tokendoesn't make sense from operational pov as the sessions doesn't need to be extended (like it happens for users that you want to silent refresh).Using
refresh_tokengrant type it's not needed because for a workload, using the jwt-bearer grant type or refresh token grant type is exactly the same, but SA'srefresh_tokengrant type isn't OAuth compliant as it doesn't requireclient_id(which is mandatory).I've tested that everything works running the

backgroundrefreshexampleChecklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)