Skip to content

Conversation

@marceljk
Copy link
Contributor

Description

relates to STACKITTPR-446

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner December 18, 2025 14:04
@marceljk marceljk force-pushed the feat/STACKITTPR-446-onboard-sfs branch 2 times, most recently from 45b914f to 677f22f Compare December 19, 2025 10:19
@marceljk marceljk force-pushed the feat/STACKITTPR-446-onboard-sfs branch from 677f22f to efef7ca Compare December 19, 2025 10:27
@github-actions
Copy link

Merging this branch changes the coverage (2 decrease, 6 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit 1.56% (-0.02%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core 21.62% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/export-policy 18.66% (+18.66%) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool 19.14% (+19.14%) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share 11.27% (+11.27%) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/snapshots 28.95% (+28.95%) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/utils 75.00% (+75.00%) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil 6.87% (-0.16%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils 84.00% (+1.54%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core/core.go 21.62% (ø) 37 8 29
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/export-policy/datasource.go 0.00% (ø) 47 (+47) 0 47 (+47)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/export-policy/resource.go 22.36% (+22.36%) 237 (+237) 53 (+53) 184 (+184) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/datasource.go 31.08% (+31.08%) 74 (+74) 23 (+23) 51 (+51) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/resource.go 15.28% (+15.28%) 229 (+229) 35 (+35) 194 (+194) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/datasource.go 21.21% (+21.21%) 66 (+66) 14 (+14) 52 (+52) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/resource.go 8.26% (+8.26%) 218 (+218) 18 (+18) 200 (+200) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/snapshots/datasource.go 28.95% (+28.95%) 76 (+76) 22 (+22) 54 (+54) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/utils/util.go 75.00% (+75.00%) 8 (+8) 6 (+6) 2 (+2) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil/testutil.go 6.87% (-0.16%) 131 (+3) 9 122 (+3) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils.go 82.28% (+2.87%) 79 (+11) 65 (+11) 14 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go 1.56% (-0.02%) 128 (+2) 2 126 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/export-policy/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/sfs_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/snapshots/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/utils/util_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils_test.go

@marceljk marceljk merged commit f190af5 into main Dec 19, 2025
3 checks passed
@marceljk marceljk deleted the feat/STACKITTPR-446-onboard-sfs branch December 19, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants