Add proposal for shared key authentication for local deployments#2570
Closed
Add proposal for shared key authentication for local deployments#2570
Conversation
Introduces a lightweight authentication mechanism for localhost MCP server deployments that provides defense-in-depth security without requiring external identity providers. The proposal includes: - Cryptographically-secure shared key generation per workload - OS keychain storage via existing encrypted secrets provider - New middleware for key validation - Transparent integration with thv proxy stdio bridge - Zero-configuration user experience with --shared-key-auth flag This addresses security concerns around unauthenticated localhost ports while maintaining simplicity for single-user local deployments.
377ee18 to
1337c0d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2570 +/- ##
==========================================
+ Coverage 54.90% 54.92% +0.02%
==========================================
Files 305 305
Lines 28712 28712
==========================================
+ Hits 15765 15771 +6
+ Misses 11544 11533 -11
- Partials 1403 1408 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
This proposal has been migrated to the toolhive-rfcs repository: stacklok/toolhive-rfcs#16 Closing this PR in favor of the migrated RFC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal introduces a lightweight authentication mechanism for localhost MCP server deployments that provides defense-in-depth security without requiring external identity providers.
Overview
The proposal adds shared key authentication as an opt-in feature for local ToolHive deployments. While localhost binding provides network-level security, this adds an additional authentication layer for defense-in-depth.
Key Features
thv proxy stdiobridge--shared-key-authflagArchitecture
The solution leverages existing ToolHive infrastructure:
Security Properties
crypto/randUsage Example
This addresses security concerns around unauthenticated localhost ports while maintaining simplicity for single-user local deployments.