Standardize proxy port field in MCPRemoteProxy#3257
Conversation
Update registry from toolhive-registry release v2025.12.16
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
==========================================
+ Coverage 65.94% 65.95% +0.01%
==========================================
Files 413 413
Lines 41070 41075 +5
==========================================
+ Hits 27082 27092 +10
+ Misses 11892 11888 -4
+ Partials 2096 2095 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks like a worthwhile change to me. @ChrisJBurns @JAORMX any concerns? |
|
@slyt3 You'll need to regenerate the CRDs. From the base of the project, run: |
Done |
|
@slyt3 Looks good, but you'll also need to bump the helm chart under After doing that, you may need to run |
|
@dmjb I remember being in favour of this but I think @JAORMX had some comments on it in a previous PR. |
done :) |
|
Uh, I had multiple Helm validation failures and CI compatibility issues, Its really IMPORTANT, because this is significant stabilization changes. Its started with minor update, but it evolved to kinda huge. its important because Pipeline unblocked after I upgraded cosign and CI caching to fix persistent release and CI failures. also removed hardcodede UIDs from helm charts. soo it will allow project to run on restrcited platforms like OpenShift. |
There was a problem hiding this comment.
@slyt3 It looks like you included some changes to the github actions, and I see your comment about running into various problems. We haven't noticed any issues with the CI in our repo, were you trying to run them in your repo?
|
@dmjb I will move the caching/CI changes to the separte branch and will open new PR for those, I hope i rebased it correctly |
de72964 to
bafa342
Compare
|
@slyt3 Thanks for splitting the PR, I'll merge this in once the build is green. |
Description:
This PR aligns MCPRemoteProxy with MCPServer by standardizing the proxy port field naming.
Summary
Details
GetProxyPort() now resolves ports in the following order:
1. proxyPort
2. port
3. default (8080)
Updated controller and deployment tests
Added test coverage to ensure proxyPort takes precedence over port
Verified existing resources using port continue to work
This improves API consistency across MCP resources while maintaining a smooth migration path for existing users.
Fixes #3102