Skip to content

Comments

Standardize proxy port field in MCPRemoteProxy#3257

Merged
dmjb merged 24 commits intostacklok:mainfrom
slyt3:fix/proxy-port-consistency
Feb 6, 2026
Merged

Standardize proxy port field in MCPRemoteProxy#3257
dmjb merged 24 commits intostacklok:mainfrom
slyt3:fix/proxy-port-consistency

Conversation

@slyt3
Copy link
Contributor

@slyt3 slyt3 commented Jan 12, 2026

Description:

This PR aligns MCPRemoteProxy with MCPServer by standardizing the proxy port field naming.

Summary

  • Added proxyPort to MCPRemoteProxySpec
  • Deprecated the legacy port field
  • Preserved backward compatibility during the transition

Details

  • GetProxyPort() now resolves ports in the following order:
    1. proxyPort
    2. port
    3. default (8080)

  • Updated controller and deployment tests

  • Added test coverage to ensure proxyPort takes precedence over port

  • Verified existing resources using port continue to work

This improves API consistency across MCP resources while maintaining a smooth migration path for existing users.

Fixes #3102

@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.95%. Comparing base (5d6121e) to head (52cc3df).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../thv-operator/api/v1alpha1/mcpremoteproxy_types.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
+ Coverage   65.94%   65.95%   +0.01%     
==========================================
  Files         413      413              
  Lines       41070    41075       +5     
==========================================
+ Hits        27082    27092      +10     
+ Misses      11892    11888       -4     
+ Partials     2096     2095       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmjb
Copy link
Contributor

dmjb commented Jan 12, 2026

This looks like a worthwhile change to me. @ChrisJBurns @JAORMX any concerns?

@dmjb
Copy link
Contributor

dmjb commented Jan 12, 2026

@slyt3 You'll need to regenerate the CRDs. From the base of the project, run:

cd cmd/thv-operator/
task crdref-gen

@slyt3
Copy link
Contributor Author

slyt3 commented Jan 12, 2026

@slyt3 You'll need to regenerate the CRDs. From the base of the project, run:


cd cmd/thv-operator/

task crdref-gen

Done

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jan 12, 2026
@dmjb
Copy link
Contributor

dmjb commented Jan 13, 2026

@slyt3 Looks good, but you'll also need to bump the helm chart under ./deploy/charts/operator-crds/Chart.yaml

After doing that, you may need to run task docs to update helm chart documentation.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jan 13, 2026
@ChrisJBurns
Copy link
Collaborator

@dmjb I remember being in favour of this but I think @JAORMX had some comments on it in a previous PR.

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jan 13, 2026
@slyt3
Copy link
Contributor Author

slyt3 commented Jan 13, 2026

@slyt3 Looks good, but you'll also need to bump the helm chart under ./deploy/charts/operator-crds/Chart.yaml

After doing that, you may need to run task docs to update helm chart documentation.

done :)

@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/XS Extra small PR: < 100 lines changed size/S Small PR: 100-299 lines changed labels Jan 13, 2026
@slyt3
Copy link
Contributor Author

slyt3 commented Jan 13, 2026

Uh, I had multiple Helm validation failures and CI compatibility issues,

Its really IMPORTANT, because this is significant stabilization changes. Its started with minor update, but it evolved to kinda huge.

its important because Pipeline unblocked after I upgraded cosign and CI caching to fix persistent release and CI failures. also removed hardcodede UIDs from helm charts. soo it will allow project to run on restrcited platforms like OpenShift.

Copy link
Contributor

@dmjb dmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slyt3 It looks like you included some changes to the github actions, and I see your comment about running into various problems. We haven't noticed any issues with the CI in our repo, were you trying to run them in your repo?

@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/S Small PR: 100-299 lines changed size/XS Extra small PR: < 100 lines changed labels Feb 2, 2026
@slyt3
Copy link
Contributor Author

slyt3 commented Feb 2, 2026

@dmjb I will move the caching/CI changes to the separte branch and will open new PR for those, I hope i rebased it correctly

@slyt3 slyt3 force-pushed the fix/proxy-port-consistency branch from de72964 to bafa342 Compare February 2, 2026 16:30
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Feb 2, 2026
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/L Large PR: 600-999 lines changed labels Feb 2, 2026
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/L Large PR: 600-999 lines changed labels Feb 2, 2026
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Feb 3, 2026
@github-actions github-actions bot added size/XS Extra small PR: < 100 lines changed and removed size/S Small PR: 100-299 lines changed labels Feb 6, 2026
@dmjb
Copy link
Contributor

dmjb commented Feb 6, 2026

@slyt3 Thanks for splitting the PR, I'll merge this in once the build is green.

@dmjb dmjb merged commit f5fd9b3 into stacklok:main Feb 6, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCPRemoteProxy should use proxyPort for consistency with MCPServer

4 participants