Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3386 +/- ##
=======================================
Coverage 65.61% 65.61%
=======================================
Files 407 407
Lines 40246 40246
=======================================
Hits 26407 26407
Misses 11779 11779
Partials 2060 2060 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
fix looks good, but could you add some testing to avoid regressions and ensure this doesn't fail again? |
yrobla
previously approved these changes
Jan 22, 2026
JAORMX
previously approved these changes
Jan 23, 2026
|
@jhrozek what's the status of this issue? |
Previously, specifying --remote-auth-bearer-token without also setting --remote-auth or --remote-auth-client-id would silently ignore the bearer token. The authentication flow was never triggered. Add shouldHandleOutgoingAuth() that also checks for bearer token configuration via flag, file, or environment variable. When a bearer token is configured, it is now used as Priority 1 in the authentication flow, before OAuth discovery. This enables using a pre-obtained bearer token for token exchange without requiring a full OAuth configuration.
jhrozek
force-pushed
the
thv-proxy-remote-bearer-file
branch
from
0ee1917 to
8123286
Compare
jhrozek
requested review from
ChrisJBurns,
amirejaz,
dmjb,
eleftherias,
lujunsan and
rdimitrov
as code owners
github-actions
bot
added
size/XS
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, specifying --remote-auth-bearer-token without also setting --remote-auth or --remote-auth-client-id would silently ignore the bearer token. The authentication flow was never triggered.
Add shouldHandleOutgoingAuth() that also checks for bearer token configuration via flag, file, or environment variable. When a bearer token is configured, it is now used as Priority 1 in the authentication flow, before OAuth discovery.
This enables using a pre-obtained bearer token for token exchange without requiring a full OAuth configuration.