Embedded Auth Server Runner Integration #3540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrunnagle
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
dmjb,
eleftherias,
jerm-dro,
jhrozek,
lujunsan and
yrobla
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
tgrunnagle
changed the base branch from
main
to
auth-server_issue-229_2026-01-28
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3540 +/- ##
==========================================
+ Coverage 65.44% 65.54% +0.10%
==========================================
Files 404 405 +1
Lines 39508 39678 +170
==========================================
+ Hits 25856 26008 +152
- Misses 11657 11669 +12
- Partials 1995 2001 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgrunnagle
force-pushed
the
auth-server_issue-230_2026-01-30
branch
from
d02114e to
a15d25b
Compare
github-actions
bot
added
size/XL
jhrozek
reviewed
Feb 2, 2026
jhrozek
previously approved these changes
Feb 2, 2026
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
one inline comment that can be fixed later, otherwise lgtm
github-actions
bot
added
size/XL
Contributor
|
✅ Large PR justification has been provided. The size review has been dismissed and this PR can now proceed with normal review. |
github-actions
bot
dismissed
their stale review
Large PR justification has been provided. Thank you!
tgrunnagle
force-pushed
the
auth-server_issue-230_2026-01-30
branch
from
a52cc19 to
f7f655d
Compare
github-actions
bot
added
size/XL
Introduce EmbeddedAuthServer wrapper in pkg/authserver/runner that integrates the authorization server with the proxy runner. The wrapper: - Transforms authserver.RunConfig to authserver.Config at runtime - Loads signing keys from files (EC/RSA PEM) with fallback support - Reads HMAC secrets from files with rotation support - Resolves upstream client secrets from files or environment variables - Performs OIDC discovery to populate authorization/token endpoints - Supports both OIDC and pure OAuth2 upstream provider types - Provides HTTP handler for OAuth/OIDC endpoints Includes comprehensive unit tests covering key provider creation, HMAC secret loading, token lifespan parsing, secret resolution, config conversions, and OIDC discovery with mock servers.
tgrunnagle
force-pushed
the
auth-server_issue-230_2026-01-30
branch
from
f7f655d to
8f5eccb
Compare
github-actions
bot
added
size/XL
jhrozek
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
EmbeddedAuthServerwrapper inpkg/authserver/runner/that bridges serializable configuration with the authorization server runtime. The wrapper:authserver.RunConfig(file paths, env var names) toauthserver.Config(resolved values) at runtimeWhy
This is the final step of the Embedded Authorization Server feature (stacklok-epics#230). It enables MCP servers running in Kubernetes to:
Run an embedded OAuth2/OIDC authorization server that authenticates users via upstream identity providers (Okta, Auth0, GitHub, etc.)
Handle secrets securely by keeping them out of serialized configuration - the
RunConfigcontains only file paths and environment variable names that are resolved at runtime from mounted Kubernetes SecretsSupport the complete MCP authentication flow where the embedded server issues tokens that downstream MCP clients use to access the MCP server's resources
Related
pkg/authserver/changes for: stacklok-epics#230Large PR Justification