ROX-28527: Send networkflows through the new iservice#2099
Draft
Molter73 wants to merge 1 commit intomauro/refactor-outputfrom
Draft
ROX-28527: Send networkflows through the new iservice#2099Molter73 wants to merge 1 commit intomauro/refactor-outputfrom
Molter73 wants to merge 1 commit intomauro/refactor-outputfrom
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## mauro/refactor-output #2099 +/- ##
=========================================================
+ Coverage 28.21% 28.37% +0.16%
=========================================================
Files 103 105 +2
Lines 6118 6184 +66
Branches 2719 2748 +29
=========================================================
+ Hits 1726 1755 +29
- Misses 3622 3657 +35
- Partials 770 772 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Molter73
force-pushed
the
mauro/refactor-output
branch
from
14555ea to
0527c42
Compare
Molter73
force-pushed
the
mauro/ROX-28527-networkflows-iservice
branch
from
d575c2b to
f658abd
Compare
Molter73
force-pushed
the
mauro/refactor-output
branch
from
0527c42 to
7d26ea8
Compare
Molter73
force-pushed
the
mauro/ROX-28527-networkflows-iservice
branch
2 times, most recently
from
43ff59e to
080c664
Compare
Molter73
force-pushed
the
mauro/ROX-28527-networkflows-iservice
branch
5 times, most recently
from
e19447b to
88af117
Compare
Molter73
force-pushed
the
mauro/ROX-28527-networkflows-iservice
branch
from
88af117 to
96bde34
Compare
Molter73
force-pushed
the
mauro/refactor-output
branch
from
7d26ea8 to
bfd611e
Compare
This is achieved by replacing the NetworkConnectionInfoServiceComm component with the Output component. TODO: - Receiving messages from sensor is not fully implemented, but the mechanisms are already in place for it. - NetworkStatusNotifierTest is broken.
Molter73
force-pushed
the
mauro/ROX-28527-networkflows-iservice
branch
from
96bde34 to
7260f39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.