Draft
Conversation
Few times over the last couple of years we have found ourselves having to update the list of VMs we use for testing manually when a family is added or removed from GCP. This is an annoying process that also turns our CI red until we get it done when an image is removed. With this change, the list of VM images to be used for RHEL and Ubuntu will be directly retrieved from GCP with a script.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## mauro/update-rhel-sap-vms #2216 +/- ##
==========================================================
Coverage 28.83% 28.83%
==========================================================
Files 96 96
Lines 5799 5799
Branches 2551 2551
==========================================================
Hits 1672 1672
Misses 3408 3408
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Few times over the last couple of years we have found ourselves having to update the list of VMs we use for testing manually when a family is added or removed from GCP. This is an annoying process that also turns our CI red until we get it done when an image is removed.
With this change, the list of VM images to be used for RHEL and Ubuntu will be directly retrieved from GCP with a script.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI is enough.