-
Notifications
You must be signed in to change notification settings - Fork 0
feat: chain groups #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces chain groups functionality to RainbowKit wallets, allowing users to select between different blockchain ecosystems when connecting wallets. The primary purpose is to organize wallets by their supported blockchain groups (starting with Ethereum) and provide a selection interface when multiple chain groups are available.
Key changes include:
- Addition of
ChainGrouptype andchainGroupproperty to wallet definitions - Implementation of chain group selection UI in both desktop and mobile connect modals
- Addition of an Ethereum chain group with all existing wallets assigned to it
Reviewed Changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rainbowkit/src/wallets/Wallet.ts | Defines ChainGroup interface and adds chainGroup property to Wallet type |
| packages/rainbowkit/src/utils/chain-groups.ts | Creates ethereumChainGroup constant for Ethereum blockchain |
| Multiple wallet connector files | Adds chainGroup: ethereumChainGroup to all wallet definitions |
| packages/rainbowkit/src/components/ConnectOptions/*.tsx | Implements chain group selection UI logic |
| packages/rainbowkit/src/locales/en_US.json | Adds localization strings for chain group selection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ? groupedByChainGroupWallets[selectedChainGroupId] || [] | ||
| : []; | ||
|
|
||
| const grouppedByGroupNameWallets = groupBy( |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'grouppedByGroupNameWallets' to 'groupedByGroupNameWallets'.
| const grouppedByGroupNameWallets = groupBy( | |
| const groupedByGroupNameWallets = groupBy( |
| ))} | ||
| </Box> | ||
| ) : ( | ||
| Object.entries(grouppedByGroupNameWallets).map( |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable name should be corrected to match the fixed spelling: 'groupedByGroupNameWallets'.
d25cb0b to
4b98969
Compare
jdomingos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces a new "chain group" selection feature to RainbowKit, enhancing both desktop and mobile wallet connection flows. Users can now select a chain group (such as Ethereum) before choosing a wallet, which enables better organization and future extensibility for multi-chain support. The update includes UI changes, new types, and logic to support chain groups, and applies these changes to all wallet connectors.
Chain Group Selection Feature
DesktopOptions.tsx) and mobile (MobileOptions.tsx) wallet connection flows, allowing users to choose a chain group before picking a wallet. UI elements and state logic have been updated accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Type and Utility Additions
ChainGrouptype and the defaultethereumChainGroupobject, and updated wallet types to include achainGroupproperty for each wallet. [1] [2] [3]ChainGrouptype from the package entry point for external use.Wallet Connector Updates
chainGroupasethereumChainGroup. [1] [2] [3] [4] [5] [6]Localization and UI Improvements
Version Bump
2.2.7to reflect these new features and improvements.