fix: unstake limits for ERC4626 #491
Merged
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 14d952e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes unstake limits for ERC4626-compliant yield opportunities by improving limit calculations and enabling amount changes for ERC4626 positions regardless of the required flag.
- Added
isERC4626utility function to detect ERC4626-compliant yields - Modified unstake amount logic to allow changes for ERC4626 positions even when not explicitly required
- Refined
getMinUnstakeAmountto apply special calculations only to Bittensor staking with higher decimal precision
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/widget/src/domain/types/yields.ts |
Adds isERC4626 utility function to check if a yield supports the ERC4626 standard |
packages/widget/src/pages/position-details/state/index.tsx |
Updates canChangeUnstakeAmount logic to allow ERC4626 positions to modify unstake amounts |
packages/widget/src/domain/types/stake.ts |
Restricts special price-per-share calculation to Bittensor staking only and increases decimal precision from 8 to 16 places |
.changeset/calm-owls-accept.md |
Registers the patch version change for the widget package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jdomingos
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a patch to the
@stakekit/widgetpackage that fixes unstake limits for ERC4626-compliant yield opportunities. The main changes improve how unstake limits are calculated and allow users to change unstake amounts for ERC4626 positions, even when the amount is not explicitly required.ERC4626 Unstake Limit Fixes:
isERC4626utility toyields.tsto detect ERC4626-compliant yield opportunities.stake.tsso that the minimum unstake amount calculation uses higher decimal precision and correctly applies integration minimums for non-Bittensor staking.position-details/state/index.tsx, users can now change unstake amounts for ERC4626 positions, even if the amount is not marked as required.General Maintenance:
isBittensorStakinginstake.ts..changeset/calm-owls-accept.md.