First commit to add a Modal about Linked notes#2891
Open
diegorv wants to merge 1 commit intostandardnotes:mainfrom
Open
First commit to add a Modal about Linked notes#2891diegorv wants to merge 1 commit intostandardnotes:mainfrom
diegorv wants to merge 1 commit intostandardnotes:mainfrom
Conversation
a05fc80 to
401cc7c
Compare
Member
|
Hey, thanks for the PR. The code itself looks good to me, but what would be the benefit of adding this when there is already the existing Linked Items button? The existing one seems better, it groups the linked items according to type and also allows to search items that are already linked and also ones that you can link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hey team, this is just a suggestion, considering that I know it might not make any sense to you.
Since it's my first time interacting with the app's source code, please feel free to conduct the code review as needed or reject the pull request hehe ;)
Current Behavior: When viewing a note, in the note header, we currently display only 5 linked tags/notes. After that, it shows "and more X...".

New Behavior: When viewing a note, in the note header, we display only the first 5 linked tags/notes as before. After that, we show a button labeled "(total count) more". When clicking the button, a modal opens displaying all the notes.

Questions:
I'm loving your application! ❤️ Congratulations on the great work! I even made sure to subscribe to the annual professional plan :)