Open
Conversation
fahad-israr
approved these changes
Feb 21, 2023
Collaborator
|
@kanha-gupta did u test this too? if yes what version of macos did u test on? |
Author
|
@fahad-israr Nope, i wanted to but Don't have access to MacOS right now, |
Collaborator
|
should be good but just need to make sure it works atleast once on a real system. try if you can else at last I'll test on my machine . |
Author
|
I am highly Doubtful if i can arrange a Mac in a short time frame. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:- #109
I have used the macOS "which" command to check if an IDE is installed in the users path.
Please review the code if its appropriate or should i resort to using path_env.contains or Files.exist method
PS- build was successful after changes
Thank you ! :)