feat: add C implementation for `stats/base/ndarray/smean` by AtharvaPatange · Pull Request #10090 · stdlib-js/stdlib

AtharvaPatange · 2026-02-05T11:13:28Z

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

feat: add C implementation for stats/base/ndarray/smean

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

#{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

- Add main.c with stdlib_stats_smean function - Add addon.c for Node.js native binding - Add smean.h header file - Add benchmark C implementation - Add binding.gyp and build configuration - Add manifest.json with dependencies Fixes #<issue-number>

stdlib-bot · 2026-02-05T11:13:39Z

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Please read our contributing guidelines if you haven't already.
For development guidance, refer to the development guide.

Next Steps

A project maintainer will approve GitHub Actions workflows for your PR.
All CI checks must pass before your submission can be fully reviewed.
You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

Sachinn-64

@AtharvaPatange There seems to be missing implementation for examples/c/example.c.
Also noticed changes in README.md, package.json, lib/main.js as well as lib/native.js. Refer https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/ndarray/smax

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

stdlib-bot · 2026-02-08T21:50:46Z

Coverage Report

No coverage information available.

Planeshifter · 2026-02-15T18:51:19Z

lib/node_modules/@stdlib/stats/base/ndarray/smean/lib/index.js

 * @license Apache-2.0
 *
-* Copyright (c) 2025 The Stdlib Authors.
+* Copyright (c) 2026 The Stdlib Authors.


This file existed before your PR with a 2025 copyright year - let's keep that as-is. We only set the current year on newly created files.

Suggested change

* Copyright (c) 2026 The Stdlib Authors.

* Copyright (c) 2025 The Stdlib Authors.

Planeshifter · 2026-02-15T18:51:21Z

lib/node_modules/@stdlib/stats/base/ndarray/smean/benchmark/benchmark.js

 * @license Apache-2.0
 *
-* Copyright (c) 2025 The Stdlib Authors.
+* Copyright (c) 2026 The Stdlib Authors.


Same here - this is an existing file, so let's revert the copyright year back to 2025.

Suggested change

* Copyright (c) 2026 The Stdlib Authors.

* Copyright (c) 2025 The Stdlib Authors.

Planeshifter · 2026-02-15T18:51:22Z

lib/node_modules/@stdlib/stats/base/ndarray/smean/test/test.js

 * @license Apache-2.0
 *
-* Copyright (c) 2025 The Stdlib Authors.
+* Copyright (c) 2026 The Stdlib Authors.


And same for this file - let's keep the original 2025 copyright year.

Suggested change

* Copyright (c) 2026 The Stdlib Authors.

* Copyright (c) 2025 The Stdlib Authors.

AtharvaPatange added 2 commits February 4, 2026 22:44

feat: add C implementation for smean

9799508

- Add main.c with stdlib_stats_smean function - Add addon.c for Node.js native binding - Add smean.h header file - Add benchmark C implementation - Add binding.gyp and build configuration - Add manifest.json with dependencies Fixes #<issue-number>

feat: add C implementation in stats/base/ndarray/smean

75c2cb7

stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 5, 2026

Sachinn-64 self-requested a review February 5, 2026 12:37

Sachinn-64 requested changes Feb 5, 2026

View reviewed changes

Sachinn-64 added the Needs Changes Pull request which needs changes before being merged. label Feb 5, 2026

AtharvaPatange added 2 commits February 6, 2026 11:58

Addressed review feedback and improvements

20af55b

Revert unintended devcontainer.json change

cb9e759

MeKaustubh07 removed the Needs Changes Pull request which needs changes before being merged. label Feb 6, 2026

Sachinn-64 previously approved these changes Feb 6, 2026

View reviewed changes

Replace isPositiveZero with isPositiveZerof

98858a8

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Sachinn-64 dismissed their stale review via 98858a8 February 8, 2026 20:37

Sachinn-64 self-requested a review February 8, 2026 20:38

Sachinn-64 previously approved these changes Feb 8, 2026

View reviewed changes

Planeshifter reviewed Feb 15, 2026

View reviewed changes

AtharvaPatange dismissed Sachinn-64’s stale review via c69f42b February 19, 2026 08:10

AtharvaPatange force-pushed the add-smean-c-implementation branch from d7019d1 to c69f42b Compare February 20, 2026 12:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat: add C implementation for `stats/base/ndarray/smean`#10090

feat: add C implementation for `stats/base/ndarray/smean`#10090
AtharvaPatange wants to merge 7 commits intostdlib-js:developfrom
AtharvaPatange:add-smean-c-implementation

AtharvaPatange commented Feb 5, 2026

Uh oh!

stdlib-bot commented Feb 5, 2026

Uh oh!

Sachinn-64 left a comment •

edited

Loading

Uh oh!

stdlib-bot commented Feb 8, 2026 •

edited

Loading

Uh oh!

Planeshifter Feb 15, 2026

Uh oh!

Planeshifter Feb 15, 2026

Uh oh!

Planeshifter Feb 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	* Copyright (c) 2026 The Stdlib Authors.
	* Copyright (c) 2025 The Stdlib Authors.

Uh oh!

Comments

Conversation

AtharvaPatange commented Feb 5, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Feb 5, 2026

Getting Started

Next Steps

Running Tests Locally

Documentation Links

Uh oh!

Sachinn-64 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sachinn-64 left a comment •

edited

Loading

stdlib-bot commented Feb 8, 2026 •

edited

Loading