bench: refactor to use string interpolation in stats/kstest#10457
Merged
Planeshifter merged 2 commits intostdlib-js:developfrom Feb 24, 2026
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
requested changes
Feb 24, 2026
Member
Planeshifter
left a comment
There was a problem hiding this comment.
Would you mind addressing the lint errors by initializing the arrays with [] and then .pushing the elements to them? Thanks in advance!
Contributor
Author
Done! Updated the array initializations to use [] and .push() in the latest commit. Thanks for the review! |
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #8647.
Description
This pull request:
@stdlib/stats/kstestto use string interpolation (@stdlib/string/format) for generating benchmark names instead of string concatenation, as outlined in the tracking issue [RFC]: use string interpolation in JavaScript benchmarks for the benchmark name (tracking issue) #8647.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used an AI coding assistant to quickly identify the locations of string concatenations in the benchmark files and to apply the
@stdlib/string/formatrefactoring consistently across the package.@stdlib-js/reviewers