feat: add complex/float32/base/div#7274
Closed
ShabiShett07 wants to merge 2 commits intostdlib-js:developfrom
Closed
feat: add complex/float32/base/div#7274ShabiShett07 wants to merge 2 commits intostdlib-js:developfrom
complex/float32/base/div#7274ShabiShett07 wants to merge 2 commits intostdlib-js:developfrom
Conversation
Contributor
Author
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
kgryte
reviewed
Jun 8, 2025
|
|
||
| var LARGE_THRESHOLD = f32( FLOAT32_BIGGEST * 0.5 ); | ||
| var SMALL_THRESHOLD = f32( FLOAT32_SMALLEST * f32( 2.0 / EPS ) ); | ||
| var RECIP_EPS_SQR = f32( 2.0 / ( EPS * EPS ) ); |
Member
There was a problem hiding this comment.
Suggested change
| var RECIP_EPS_SQR = f32( 2.0 / ( EPS * EPS ) ); | |
| var RECIP_EPS_SQR = f32( 2.0 / f32( EPS * EPS ) ); |
kgryte
reviewed
Jun 8, 2025
| * See section 3.6 in https://arxiv.org/pdf/1210.4539.pdf. | ||
| * | ||
| * ```text | ||
| * q[0]: 0011111111100011001100110011001100110011001100110011001100110100 |
Member
There was a problem hiding this comment.
These rather obviously need to be updated. We are dealing with single-precision, so we should be using 32-bit sequences. I suggest reading the referenced paper and seeing if they mention anything about single-precision.
Member
|
This PR has been superseded by #9371. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
none
Description
This pull request:
complex/float32/base/divRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers