feat!: migrate utils/move-property to object/move-property#8778
feat!: migrate utils/move-property to object/move-property#8778opbot-xd wants to merge 4 commits intostdlib-js:developfrom
utils/move-property to object/move-property#8778Conversation
Ref: #8755 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
This commit removes the `moveProperty` symbol from the `@stdlib/utils` namespace due to a package migration. BREAKING CHANGE: remove `moveProperty` To migrate, users should access the same symbol via the `@stdlib/object` namespace. Ref: #8755
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
The lint check failure appears to be related to pre-existing OOM issues when linting Examples run successfully locally. |
This commit removes `@stdlib/utils/move-property` in favor of `@stdlib/object/move-property`. BREAKING CHANGE: remove `utils/move-property` To migrate, users should update their require/import paths to use `@stdlib/object/move-property` which provides the same API and implementation. Ref: #8755
86e5546 to
f7d128e
Compare
|
I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue". Why this matters: Required action: Thank you for your contribution to the project! |
| import writablePropertySymbols = require( '@stdlib/utils/writable-property-symbols' ); | ||
| import writablePropertySymbolsIn = require( '@stdlib/utils/writable-property-symbols-in' ); | ||
| import zip = require( '@stdlib/utils/zip' ); | ||
| import any = require('@stdlib/utils/any'); |
There was a problem hiding this comment.
All of these style changes should not have been made.
| * @see {@link module:@stdlib/utils/any} | ||
| */ | ||
| setReadOnly( utils, 'any', require( '@stdlib/utils/any' ) ); | ||
| setReadOnly(utils, 'any', require( '@stdlib/utils/any' )); |
There was a problem hiding this comment.
Same comment. None of these style changes should have been made.
There was a problem hiding this comment.
This change should not have been made in this commit.
|
@opbot-xd Thank you for looking into this. However, I am going to go ahead and close this PR, as your changes include several style changes which are not desired. Feel free to submit another PR which avoids such changes. |
utils/move-property to object/move-propertyutils/move-property to object/move-property
Progresses #8755 (partial).
Description
This pull request:
@stdlib/utils/move-propertyto@stdlib/object/move-propertyas the first package migration in RFC [RFC]: migrateutilspackages toobject(tracking issue) #8755@stdlib/object/move-propertypackage with updated namespace referencesmovePropertyfrom the@stdlib/utilsnamespace@stdlib/utils/move-propertypackageNote: This PR addresses only the
utils/move-property => object/move-propertymigration. The remaining 10 packages listed in RFC #8755 will be handled in separate PRs as per the stdlib contributing guidelines for package migrations.Related Issues
This pull request has the following related issues:
utilspackages toobject(tracking issue) #8755Questions
No.
Other
This PR follows the same approach as #8736 which was used as a reference for the migration process.
Breaking Changes:
movePropertyis no longer accessible viarequire('@stdlib/utils').moveProperty@stdlib/utils/move-propertypackage is removedMigration: Users should update their require/import paths from
@stdlib/utils/move-propertyto@stdlib/object/move-property.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used AI assistance for researching the stdlib codebase structure and understanding the package migration guidelines. The actual code changes were authored following the stdlib moving packages documentation and #8736 as reference.
@stdlib-js/reviewers