Skip to content

Comments

chore: fix JavaScript lint errors (issue #8876)#8886

Merged
kgryte merged 2 commits intostdlib-js:developfrom
anoofmhd:lint
Dec 9, 2025
Merged

chore: fix JavaScript lint errors (issue #8876)#8886
kgryte merged 2 commits intostdlib-js:developfrom
anoofmhd:lint

Conversation

@anoofmhd
Copy link
Contributor

@anoofmhd anoofmhd commented Dec 8, 2025

Resolves #8876 .

Description

Fix linting error: Replace new Array() with safe Array creation to follow stdlib/no-new-array rule.

This pull request:

  • Using the new Array() constructor is not allowed; use an array literal with push instead.

Related Issues

No

This pull request has the following related issues:

  • No

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Dec 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 8, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/is-configurable-property-in $\color{green}118/118$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}118/118$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 9, 2025
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte merged commit 674526c into stdlib-js:develop Dec 9, 2025
12 checks passed
@anoofmhd
Copy link
Contributor Author

anoofmhd commented Dec 9, 2025

Thank you for reviewing and merging the PR! Happy to contribute

@anoofmhd anoofmhd deleted the lint branch December 9, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants