Skip to content

Comments

bench: refactor to use dynamic memory allocation in blas/base/cscal#8887

Merged
kgryte merged 2 commits intostdlib-js:developfrom
ishwarthecodddr:bench-cscal-dynamic-alloc
Dec 9, 2025
Merged

bench: refactor to use dynamic memory allocation in blas/base/cscal#8887
kgryte merged 2 commits intostdlib-js:developfrom
ishwarthecodddr:bench-cscal-dynamic-alloc

Conversation

@ishwarthecodddr
Copy link
Contributor

Resolves part of #8463

Description

What is the purpose of this pull request?

This pull request replaces static memory allocation in C benchmarks with dynamic memory allocation in @stdlib/blas/base/cscal

Related Issues

Does this pull request have any related issues?

[RFC]: replace static memory allocation of large arrays in C benchmarks with dynamic memory allocation (tracking issue) #8643

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • [] No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 8, 2025

Coverage Report

Package Statements Branches Functions Lines
blas/base/cscal $\color{green}379/379$
$\color{green}+0.00%$
$\color{green}17/17$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}379/379$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Benchmarks Pull requests adding or improving benchmarks for measuring performance. and removed Needs Review A pull request which needs code review. labels Dec 9, 2025
@kgryte kgryte changed the title bench: refactor to use dynamic memory allocation in 'blas/base/cscal' bench: refactor to use dynamic memory allocation in blas/base/cscal Dec 9, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 8ffe947 into stdlib-js:develop Dec 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants