Skip to content

Comments

bench: refactor to use dynamic memory allocation in blas/ext/base/dsum#8907

Merged
kgryte merged 1 commit intostdlib-js:developfrom
opbot-xd:bench-dsum-dynamic-alloc
Dec 9, 2025
Merged

bench: refactor to use dynamic memory allocation in blas/ext/base/dsum#8907
kgryte merged 1 commit intostdlib-js:developfrom
opbot-xd:bench-dsum-dynamic-alloc

Conversation

@opbot-xd
Copy link
Contributor

@opbot-xd opbot-xd commented Dec 9, 2025


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed

Progresses #8643.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the C benchmarks for @stdlib/blas/ext/base/dsum to use dynamic memory allocation instead of static memory allocation for large arrays.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This PR replaces static array declarations (e.g., double x[ len ]) with dynamic memory allocation using malloc() and free() to prevent potential segmentation faults on systems with limited stack memory.

Changes made:

  • Replaced double x[ len ]; with double *x;
  • Added x = (double *)malloc( len * sizeof( double ) );
  • Added NULL check for allocation failure
  • Added free( x ); before returning

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Dec 9, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 9, 2025

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsum $\color{green}345/345$
$\color{green}+0.00%$
$\color{green}13/13$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}345/345$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@opbot-xd opbot-xd force-pushed the bench-dsum-dynamic-alloc branch from cbed170 to 9eae35a Compare December 9, 2025 07:42
@kgryte kgryte added Benchmarks Pull requests adding or improving benchmarks for measuring performance. and removed Needs Review A pull request which needs code review. labels Dec 9, 2025
@kgryte kgryte changed the title bench: refactor to use dynamic memory allocation in blas/ext/base/dsum bench: refactor to use dynamic memory allocation in blas/ext/base/dsum Dec 9, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 2b8dee8 into stdlib-js:develop Dec 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants