Skip to content

Comments

feat: add constants/float16/sqrt-three#8986

Merged
kgryte merged 5 commits intostdlib-js:developfrom
Amansingh0807:feat-float16-sqrt-three
Dec 16, 2025
Merged

feat: add constants/float16/sqrt-three#8986
kgryte merged 5 commits intostdlib-js:developfrom
Amansingh0807:feat-float16-sqrt-three

Conversation

@Amansingh0807
Copy link
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • add constants/float64/sqrt-three

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 12, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float16/sqrt-three $\color{green}51/51$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}51/51$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Amansingh0807 Amansingh0807 force-pushed the feat-float16-sqrt-three branch from 956dfea to 83796ae Compare December 12, 2025 07:56
@Amansingh0807
Copy link
Contributor Author

Thanks for the review, @Neerajpathak07!
I have implemented both suggestions - removed the auto-populated content from the related section and the related-links area. Changes pushed!

Appreciate the clarification! 🙏

@Neerajpathak07
Copy link
Member

Just a small advice do try and avoid force pushing commits reason being when contributors pull from your work it causes merge conflicts which are pretty tedious to resolve.
If an unwanted commit was added it is viable to close the pr and create a new one.

@Amansingh0807
Copy link
Contributor Author

Thank you for the advice, @Neerajpathak07!
I completely understand - I will avoid force pushing to prevent merge conflicts. Will use revert or create a new PR if needed to undo commits.
Really appreciate you taking the time to guide me on best practices. I will keep this in mind going forward. 😊

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Dec 16, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit 772e753 into stdlib-js:develop Dec 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants