feat: add `blas/ext/base/ndarray/srev` by Amansingh0807 · Pull Request #9045 · stdlib-js/stdlib

Amansingh0807 · 2025-12-14T17:23:00Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

add blas/ext/base/ndarray/srev

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Implementation Notes:

Stride Handling: The implementation correctly handles negative strides. The target index iy is calculated relative to the offset (iy = ix + (N-1)*stride), ensuring the logical view is reversed regardless of the underlying memory traversal direction.
Type Safety: Following the pattern of existing BLAS ndarray implementations, explicit runtime type validation is omitted to prioritize performance in the inner loop. The implementation relies on TypeScript definitions and upstream ndarray constraints.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

stdlib-bot · 2025-12-14T17:24:41Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/ndarray/srev	$\color{red}174/176$ $\color{green}+0.00%$	$\color{red}10/11$ $\color{green}+0.00%$	$\color{green}1/1$ $\color{green}+0.00%$	$\color{red}174/176$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Amansingh0807 · 2026-01-10T06:31:10Z

/stdlib merge

Amansingh0807 · 2026-01-10T06:34:40Z

/stdlib update-copyright-years

Amansingh0807 · 2026-01-10T08:04:17Z

@Planeshifter Hi! I noticed you were reviewing similar PR today.

I've just updated the copyright years in this one to keep it current. Since you are already in this context, could you please take a quick look here as well whenever you have a moment? Thanks!

Planeshifter

Thanks for this PR!

Planeshifter · 2026-01-10T17:59:41Z

lib/node_modules/@stdlib/blas/ext/base/ndarray/srev/package.json

+  "scripts": {
+    "test": "make test",
+    "test-cov": "make test-cov",
+    "examples": "make examples",
+    "benchmark": "make benchmark"
+  },
+  "homepage": "https://github.com/stdlib-js/stdlib",
+  "repository": {
+    "type": "git",
+    "url": "git://github.com/stdlib-js/stdlib.git"
+  },
+  "bugs": {
+    "url": "https://github.com/stdlib-js/stdlib/issues"
+  },
+  "dependencies": {
+    "@stdlib/math/base/special/floor": "^0.2.2",
+    "@stdlib/ndarray/base/data-buffer": "^0.2.1",
+    "@stdlib/ndarray/base/numel-dimension": "^0.2.1",
+    "@stdlib/ndarray/base/offset": "^0.2.1",
+    "@stdlib/ndarray/base/stride": "^0.2.1"
+  },
+  "devDependencies": {
+    "@stdlib/array/float32": "^0.2.2",
+    "@stdlib/ndarray/base/ctor": "^0.2.2",
+    "@stdlib/random/base/randu": "^0.2.1",
+    "tape": "git+https://github.com/kgryte/tape.git#fix/globby",
+    "istanbul": "^0.4.1",
+    "tap-min": "git+https://github.com/Planeshifter/tap-min.git",
+    "bench": "git+https://github.com/kgryte/bench.git"
+  },


scripts, dependencies, and devDependencies objects should be empty objects since these are auto-generated during package creation.

Planeshifter · 2026-01-10T17:59:42Z

lib/node_modules/@stdlib/blas/ext/base/ndarray/srev/package.json

+    "float",
+    "single"
+  ]
+}


Please add:

"__stdlib__": {}

before the closing brace.

Planeshifter · 2026-01-10T17:59:43Z

lib/node_modules/@stdlib/blas/ext/base/ndarray/srev/test/test.js

+
+// MODULES //
+
+var tape = require( 'tape' ); // eslint-disable-line node/no-unpublished-require


Suggested change

var tape = require( 'tape' ); // eslint-disable-line node/no-unpublished-require

var tape = require( 'tape' );

Amansingh0807 · 2026-01-11T05:32:57Z

/stdlib merge

Amansingh0807 · 2026-01-11T05:35:19Z

/stdlib update-copyright-years

Amansingh0807 · 2026-01-11T05:36:37Z

Hi @Planeshifter All requested changes have been applied. Ready for re-review. Thanks!

feat: implement ndarray/srev package

03b9166

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 14, 2025

Amansingh0807 added 2 commits December 14, 2025 22:59

fix: resolve CI linting errors

992d287

fix: add semicolon in repl.txt and eslint disable for tape

cc12f35

kgryte added the Feature Issue or pull request for adding a new feature. label Dec 16, 2025

Amansingh0807 added 2 commits December 19, 2025 18:57

docs: update return annotations to use ndarray instance notation

54e9b05

fix: use mutation notation for void-returning srev function

7fd19f5

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 20, 2025

Amansingh0807 added 2 commits December 21, 2025 17:45

fix: apply all dsorthp pattern fixes to srev

ed070a3

fix: srev benchmark - use @stdlib/string/format per RFC stdlib-js#8647

c94548a

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 10, 2026

Planeshifter requested changes Jan 11, 2026

View reviewed changes

fix package.json file and test.j

4758f53

Amansingh0807 force-pushed the feat-ndarray-srev branch from 7ab6a12 to 4758f53 Compare January 11, 2026 05:31

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2026

Merge remote-tracking branch 'upstream/develop' into feat-ndarray-srev

2bc66ef

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2026

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2026

chore: update copyright years

6d6486f

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2026

Amansingh0807 requested a review from Planeshifter January 13, 2026 06:07

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat: add `blas/ext/base/ndarray/srev`#9045

feat: add `blas/ext/base/ndarray/srev`#9045
Amansingh0807 wants to merge 10 commits intostdlib-js:developfrom
Amansingh0807:feat-ndarray-srev

Amansingh0807 commented Dec 14, 2025 •

edited

Loading

Uh oh!

stdlib-bot commented Dec 14, 2025 •

edited

Loading

Uh oh!

Amansingh0807 commented Jan 10, 2026

Uh oh!

Amansingh0807 commented Jan 10, 2026

Uh oh!

Amansingh0807 commented Jan 10, 2026

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Jan 10, 2026

Uh oh!

Planeshifter Jan 10, 2026

Uh oh!

Planeshifter Jan 10, 2026

Uh oh!

Amansingh0807 commented Jan 11, 2026

Uh oh!

Amansingh0807 commented Jan 11, 2026

Uh oh!

Amansingh0807 commented Jan 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		// MODULES //

		var tape = require( 'tape' ); // eslint-disable-line node/no-unpublished-require

	var tape = require( 'tape' ); // eslint-disable-line node/no-unpublished-require
	var tape = require( 'tape' );

Uh oh!

Comments

Conversation

Amansingh0807 commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Implementation Notes:

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Amansingh0807 commented Jan 10, 2026

Uh oh!

Amansingh0807 commented Jan 10, 2026

Uh oh!

Amansingh0807 commented Jan 10, 2026

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

Amansingh0807 commented Jan 11, 2026

Uh oh!

Amansingh0807 commented Jan 11, 2026

Uh oh!

Amansingh0807 commented Jan 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Amansingh0807 commented Dec 14, 2025 •

edited

Loading

stdlib-bot commented Dec 14, 2025 •

edited

Loading