feat: add blas/ext/base/ndarray/drev#9056
feat: add blas/ext/base/ndarray/drev#9056Amansingh0807 wants to merge 6 commits intostdlib-js:developfrom
blas/ext/base/ndarray/drev#9056Conversation
- Add ndarray wrapper for drev function - Implement comprehensive test suite with stride/offset tests - Add documentation (README, REPL, TypeScript types) - Add examples and performance benchmarks - Follow stdlib conventions for BLAS operations
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
|
||
| // The function returns an ndarray... | ||
| { | ||
| const Float64Array = require( '@stdlib/array/float64' ); |
There was a problem hiding this comment.
No imports in blocks like this. See other packages.
There was a problem hiding this comment.
Thanks for the catch. I've updated docs/types/test.ts to use top-level imports, consistent with other packages. Ready for review.
|
|
||
| The function has the following parameters: | ||
|
|
||
| - **x**: input ndarray. |
There was a problem hiding this comment.
This isn't correct. We should always be providing an array of ndarrays. In this case, an array containing a single one-dimensional input ndarray.
| * drev( x ); | ||
| * // x => <ndarray>[ 3.0, 2.0, 1.0 ] | ||
| */ | ||
| declare function drev( x: float64ndarray ): float64ndarray; |
There was a problem hiding this comment.
This needs to be fixed. All of these base/ndarray APIs need to always take an array of ndarrays. That is the expectation from higher level consumers.
kgryte
left a comment
There was a problem hiding this comment.
Left initial comments. In short, need to follow more closely the precedents established in other similar packages.
84fc3e6 to
b9e2010
Compare
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
Resolves None.
Description
This pull request:
blas/ext/base/ndarray/drevRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers