Skip to content

Comments

feat: add blas/ext/base/ndarray/gfill#9078

Open
Amansingh0807 wants to merge 6 commits intostdlib-js:developfrom
Amansingh0807:feat-ndarray-gfill
Open

feat: add blas/ext/base/ndarray/gfill#9078
Amansingh0807 wants to merge 6 commits intostdlib-js:developfrom
Amansingh0807:feat-ndarray-gfill

Conversation

@Amansingh0807
Copy link
Contributor

@Amansingh0807 Amansingh0807 commented Dec 16, 2025 •
edited
Loading

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/ndarray/gfill

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@Amansingh0807
feat: add @stdlib/blas/ext/base/ndarray/gfill
5e264b4 
Implements generic fill function for one-dimensional ndarrays.
- Fills ndarray with any JavaScript value (numbers, objects, etc.)
- Wraps existing strided gfill.ndarray implementation
- Supports non-unit strides, negative strides, and offsets
- Includes comprehensive tests, examples, benchmarks, and TypeScript definitions
Signature: gfill( x, alpha ) returns x (transformation operation)
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/gfill $\color{green}120/120$
$\color{green}+0.00%$ 		$\color{green}3/3$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}120/120$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Amansingh0807
fix: correct object literal formatting in gfill test
75f03bc 
- Fix ESLint object-curly-newline error on line 96
- Object literals must use multi-line format per stdlib style guide
@Amansingh0807
docs: update return annotations to use ndarray instance notation
1c6cb31
kgryte
kgryte requested changes Dec 20, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has all the same issues as the PR for dapx.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Dec 20, 2025
@kgryte kgryte added Needs Discussion Needs further discussion. status: Blocked Issue or pull request which is currently blocked. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Needs Discussion Needs further discussion. status: Blocked Issue or pull request which is currently blocked.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Amansingh0807 @stdlib-bot @kgryte