Skip to content

Comments

feat: add blas/ext/base/ndarray/cfill#9179

Closed
Amansingh0807 wants to merge 4 commits intostdlib-js:developfrom
Amansingh0807:feat-ndarray-cfill
Closed

feat: add blas/ext/base/ndarray/cfill#9179
Amansingh0807 wants to merge 4 commits intostdlib-js:developfrom
Amansingh0807:feat-ndarray-cfill

Conversation

@Amansingh0807
Copy link
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/ndarray/cfill

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Implementation Notes:

  • Wrapper Strategy: Delegates logic to @stdlib/blas/ext/base/cfill. It extracts the data buffer (using getData), stride, and offset from the input ndarray.

  • Complex Handling: The function accepts a Complex64 object as alpha and passes it directly to the base implementation.

  • Data View: Uses getData() to access the underlying buffer. The base implementation handles the interleaving of real and imaginary components.

  • Style Compliance: Variable declarations are sorted by line length (descending) in accordance with the project's style guide.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 17, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2025

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/cfill $\color{green}123/123$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}123/123$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Amansingh0807 Amansingh0807 marked this pull request as draft December 17, 2025 14:18
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants