Skip to content

Comments

chore: fix JavaScript lint errors (issue #8586)#9252

Closed
munazzaghazali7-hash wants to merge 11 commits intostdlib-js:developfrom
munazzaghazali7-hash:fix-eslint-files-missing-files
Closed

chore: fix JavaScript lint errors (issue #8586)#9252
munazzaghazali7-hash wants to merge 11 commits intostdlib-js:developfrom
munazzaghazali7-hash:fix-eslint-files-missing-files

Conversation

@munazzaghazali7-hash
Copy link
Contributor

Resolves #8586 .

Description

What is the purpose of this pull request?

This pull request:

  • Description

Fixes JavaScript linting failures caused by ESLint being invoked on files that no longer exist.

The eslint-files rule now skips missing files, preventing ENOENT errors in CI when file lists include deleted paths.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

munazzaghazali7-hash and others added 11 commits December 17, 2025 13:58
Replaced broken LAPACK link with archived version.


Signed-off-by: Almunazza <munazzaghazali7@gmail.com>
docs: fix broken Markdown link in has-has-instance-symbol-support

Replaced the broken MDN link for `Symbol.hasInstance` in 
`lib/node_modules/@stdlib/assert/has-has-instance-symbol-support/README.md` 
with the updated URL from MDN.

Resolves stdlib-js#9125

Signed-off-by: Almunazza <munazzaghazali7@gmail.com>
Replaced the broken LAPACK explore html link in
lib/node_modules/@stdlib/blas/base/ssyr2/README.md with a working
URL pointing to the ssyr2 documentation.

Resolves stdlib-js#9112

Signed-off-by: Almunazza <munazzaghazali7@gmail.com>
Signed-off-by: Almunazza <munazzaghazali7@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Replaced a broken LAPACK explore HTML link in
lib/node_modules/@stdlib/lapack/base/dlaset/README.md
with an archived version from the Wayback Machine.

Resolves stdlib-js#9149 


Signed-off-by: Almunazza <munazzaghazali7@gmail.com>


Updated the broken link in docs/styleguides/javascript/README.md pointing to http://sideeffect.kr/popularconvention/#javascript

Signed-off-by: Almunazza <munazzaghazali7@gmail.com>
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. labels Dec 19, 2025
@kgryte
Copy link
Member

kgryte commented Dec 20, 2025

This PR does not actually address the lint error. As such, I will go ahead and close, as none of the proposed changes are desired.

Thank you for your interest in stdlib, and we look forward to your future contributions! 🚀

@kgryte kgryte closed this Dec 20, 2025
@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. labels Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

4 participants