docs: improve doctests for ndarray instances in ndarray/count-falsy#9377
Merged
kgryte merged 1 commit intostdlib-js:developfrom Dec 26, 2025
Merged
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Needs Review
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
added
Documentation
kgryte
approved these changes
Dec 26, 2025
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing, @kaushal-kumar-it!
kaushal-kumar-it
deleted the
docs/update-ndarray-doctests-count-falsy
branch
Contributor
Author
|
Appreciate the feedback! @kgryte |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Progresses #9329.
Description
This pull request improves doctests for ndarray instances in the
ndarray/count-falsypackage.Specifically, it replaces explicit element access using
get()in REPL documentation with the new compact ndarray instance notation (e.g.,<ndarray>[ 1 ]). This aligns the package documentation with the behavior demonstrated in commit46d9a44and the corresponding RFC.No other example logic or behavior was modified.
Related Issues
None.
Questions
No.
Other
No additional notes.
Checklist
AI Assistance
@stdlib-js/reviewers