feat: add number/float16/base/signbit#9390
Merged
kgryte merged 13 commits intostdlib-js:developfrom Dec 30, 2025
Merged
Conversation
Member
Author
|
/stdlib update-copyright-years |
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
Author
|
Given that Repl error is not caused to know changes related to this PR hence I'll go ahead and open this for Review! |
Neerajpathak07
commented
Dec 27, 2025
Neerajpathak07
commented
Dec 27, 2025
Neerajpathak07
commented
Dec 28, 2025
lib/node_modules/@stdlib/number/float16/base/signbit/benchmark/c/benchmark.c
Show resolved
Hide resolved
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Neerajpathak07
commented
Dec 28, 2025
lib/node_modules/@stdlib/number/float16/base/signbit/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Member
Author
|
staying consistent with the |
gururaj1512
requested changes
Dec 30, 2025
lib/node_modules/@stdlib/number/float16/base/signbit/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/number/float16/base/signbit/manifest.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com> Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Co-authored-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com> Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
Member
Author
|
@gururaj1512 Thank you for catching this!! |
gururaj1512
previously approved these changes
Dec 30, 2025
kgryte
reviewed
Dec 30, 2025
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 30, 2025
lib/node_modules/@stdlib/number/float16/base/signbit/examples/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 30, 2025
lib/node_modules/@stdlib/number/float16/base/signbit/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 30, 2025
lib/node_modules/@stdlib/number/float16/base/signbit/src/addon.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 30, 2025
lib/node_modules/@stdlib/number/float16/base/signbit/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Dec 30, 2025
lib/node_modules/@stdlib/number/float16/base/signbit/test/test.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
Member
|
As the CI failure is expected, I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves none.
Description
This pull request:
number/float16/base/signbitRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers