chore: fix JavaScript lint errors (issue #9419)#9427
chore: fix JavaScript lint errors (issue #9419)#9427kgryte merged 2 commits intostdlib-js:developfrom
Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
In this case, using new Array() is intentional, as we explicitly want to create a sparse array. As such, the appropriate change was to simply disable the lint rule.
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Thank you for your contribution and congratulations on your first PR! |
Thank you! |
Resolves #9419.
Description
This pull request:
Cause and Solution of the issue:
new Array()declaration for creating 'sparse array'Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers