Skip to content

Comments

feat: add stats/incr/nanmidrange#9432

Closed
sanki92 wants to merge 1 commit intostdlib-js:developfrom
sanki92:feat/stats-incr-nanmidrange
Closed

feat: add stats/incr/nanmidrange#9432
sanki92 wants to merge 1 commit intostdlib-js:developfrom
sanki92:feat/stats-incr-nanmidrange

Conversation

@sanki92
Copy link

@sanki92 sanki92 commented Dec 30, 2025

Add stats/incr/nanmidrange

Resolves #5578.

Description

What is the purpose of this pull request?

This pull request:

  • Adds @stdlib/stats/incr/nanmidrange package for incrementally computing mid-range while ignoring NaN values
  • Implements the accumulator following the same pattern as other nan* packages in the stats/incr namespace
  • Uses a thin wrapper around @stdlib/stats/incr/midrange that skips NaN inputs

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The implementation follows the established pattern from @stdlib/stats/incr/nanmin and @stdlib/stats/incr/nansum. The package wraps the existing incrmidrange accumulator and filters out NaN values before passing them through.

All standard package files are included:

  • Main implementation (lib/)
  • Comprehensive tests with NaN handling scenarios
  • Example demonstrating usage with NaN values
  • Benchmark suite
  • TypeScript definitions
  • REPL documentation

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used AI to understand the codebase structure and identify the appropriate pattern to follow from existing nan* packages. The implementation was manually written by adapting the midrange package with the NaN-handling wrapper pattern observed in nanmin and nansum.


@stdlib-js/reviewers

- Add incremental accumulator for computing mid-range while ignoring NaN values
- Based on stats/incr/midrange with NaN handling pattern from nanmin/nansum
- Includes tests, examples, benchmarks, and TypeScript definitions

Closes stdlib-js#5578
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Dec 30, 2025
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Dec 30, 2025
@sanki92 sanki92 closed this Dec 30, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmidrange

2 participants