feat: add stats/incr/nanmidrange#9432
Closed
sanki92 wants to merge 1 commit intostdlib-js:developfrom
Closed
Conversation
- Add incremental accumulator for computing mid-range while ignoring NaN values - Based on stats/incr/midrange with NaN handling pattern from nanmin/nansum - Includes tests, examples, benchmarks, and TypeScript definitions Closes stdlib-js#5578
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
stats/incr/nanmidrangeResolves #5578.
Description
This pull request:
@stdlib/stats/incr/nanmidrangepackage for incrementally computing mid-range while ignoringNaNvaluesnan*packages in thestats/incrnamespace@stdlib/stats/incr/midrangethat skipsNaNinputsRelated Issues
This pull request has the following related issues:
stats/incr/nanmidrange#5578 (parent tracking issue: [RFC]: add incremental accumulators for handlingNaNvalues instats/incr/*(tracking issue) #5966)Questions
No.
Other
The implementation follows the established pattern from
@stdlib/stats/incr/nanminand@stdlib/stats/incr/nansum. The package wraps the existingincrmidrangeaccumulator and filters outNaNvalues before passing them through.All standard package files are included:
lib/)Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Used AI to understand the codebase structure and identify the appropriate pattern to follow from existing
nan*packages. The implementation was manually written by adapting themidrangepackage with the NaN-handling wrapper pattern observed innanminandnansum.@stdlib-js/reviewers