Skip to content

Comments

feat: add number/float16/base/add#9442

Draft
Neerajpathak07 wants to merge 13 commits intostdlib-js:developfrom
Neerajpathak07:float16/base/add
Draft

feat: add number/float16/base/add#9442
Neerajpathak07 wants to merge 13 commits intostdlib-js:developfrom
Neerajpathak07:float16/base/add

Conversation

@Neerajpathak07
Copy link
Member

@Neerajpathak07 Neerajpathak07 commented Dec 30, 2025

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds number/float16/base/add

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@Neerajpathak07 Neerajpathak07 added the Feature Issue or pull request for adding a new feature. label Dec 30, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 30, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
number/float16/base/add $\color{green}177/177$
$\color{green}+0.00%$ 		$\color{green}5/5$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}177/177$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 30, 2025 17:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 30, 2025
Lokeshranjan8
Lokeshranjan8 reviewed Dec 31, 2025
View reviewed changes
Neerajpathak07
Neerajpathak07 commented Dec 31, 2025
View reviewed changes
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 2, 2026 13:42
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 2, 2026
@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Jan 2, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2026
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 2, 2026 13:55
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 2, 2026
@Neerajpathak07 Neerajpathak07 added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Jan 2, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2026
@Neerajpathak07 Neerajpathak07 added the Needs Review A pull request which needs code review. label Jan 2, 2026
gururaj1512
gururaj1512 requested changes Jan 2, 2026
View reviewed changes
@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Jan 2, 2026 •
edited
Loading

@gururaj1512 Thanks for reviewing and flagging changes although I do have a few conflicting opinions on the description of examples!!

@Neerajpathak07 Neerajpathak07 added the JavaScript Issue involves or relates to JavaScript. label Jan 3, 2026
kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
@kgryte
Apply suggestions from code review
5d2e388 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
@kgryte
docs: update example
8a1b051 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
8ff5d43 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
lib/node_modules/@stdlib/number/float16/base/add/benchmark/c/benchmark.c
Comment on lines +97 to +98
double elapsed;
stdlib_float16_t z;
Copy link
Member

@kgryte kgryte Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
double elapsed;
stdlib_float16_t z;
stdlib_float16_t z;
double elapsed;

Copy link
Member

@kgryte kgryte Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order by length.

kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
lib/node_modules/@stdlib/number/float16/base/add/benchmark/c/benchmark.c
t = tic();
for ( i = 0; i < ITERATIONS; i++ ) {
z = stdlib_base_float16_add( x[ i%100 ], y[ i%100 ] );
if ( z != z ) {
Copy link
Member

@kgryte kgryte Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work the way you need it to. You need to compare against the bit sequence value for NaN. We do this in other benchmarks for float16.

Copy link
Member

@kgryte kgryte Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better would be to use the eventual number/float16/base/assert/is-nan utility here.

kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
lib/node_modules/@stdlib/number/float16/base/add/package.json
]
}
],
"output_policy": "same",
Copy link
Member

@kgryte kgryte Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"output_policy": "same",

We can remove this, as this particular field was later found to be unnecessary at this level.

kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
lib/node_modules/@stdlib/number/float16/base/add/src/addon.c
Copy link
Member

@kgryte kgryte Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neerajpathak07 We should go ahead and add the binary macro for half-precision HH_H. Would you mind opening a PR for this?

Copy link
Member Author

@Neerajpathak07 Neerajpathak07 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah will do it

kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
lib/node_modules/@stdlib/number/float16/base/add/test/test.js
// MODULES //

var tape = require( 'tape' );
var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
Copy link
Member

@kgryte kgryte Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should go ahead and create a half-precision utility for this at number/float16/base/assert/is-negative-zero. Same thing for is-positive-zero and is-nan.

We'll eventually be moving math/base/assert/is-negative-zero to number/float64/base/assert/is-negative-zero, so we might as well go ahead and pre-emptively add the half-precision utilities.

Copy link
Member Author

@Neerajpathak07 Neerajpathak07 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add a PR soon for that!!

kgryte
kgryte reviewed Jan 6, 2026
View reviewed changes
lib/node_modules/@stdlib/number/float16/base/add/test/test.native.js

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );
Copy link
Member

@kgryte kgryte Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment.

kgryte
kgryte requested changes Jan 6, 2026
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 6, 2026
@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Jan 6, 2026

Will draft this PR for the time being till we add the macro and the utilities!!

@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 6, 2026 03:17
@Neerajpathak07 Neerajpathak07 mentioned this pull request Jan 8, 2026
Open
3 tasks
@Lokeshranjan8 Lokeshranjan8 mentioned this pull request Jan 8, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

@gururaj1512 gururaj1512 gururaj1512 requested changes

+1 more reviewer

@Lokeshranjan8 Lokeshranjan8 Lokeshranjan8 left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Neerajpathak07 @stdlib-bot @kgryte @gururaj1512 @Lokeshranjan8