feat: add `blas/ext/base/dsortnans` by anandkaranubc · Pull Request #9445 · stdlib-js/stdlib

anandkaranubc · 2025-12-30T19:38:21Z

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

Adds the implementation of dsortnans which partitions a double-precision floating-point strided array by moving all NaNs either to the beginning or the end of the array.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Resolves None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

anandkaranubc · 2025-12-30T19:40:10Z

lib/node_modules/@stdlib/blas/ext/base/dsortnans/lib/dsortnans.js

+* -   The algorithm is not stable, meaning that the relative order of non-NaN elements is not guaranteed to be preserved.
+*
+* @param {PositiveInteger} N - number of indexed elements
+* @param {number} order - NaN placement order


Suggested change

* @param {number} order - NaN placement order

* @param {number} order - NaN placement order

Is the naming convention acceptable here?

stdlib-bot · 2025-12-30T19:40:38Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/dsortnans	$\color{green}418/418$ $\color{green}+0.00%$	$\color{green}31/31$ $\color{green}+0.00%$	$\color{green}4/4$ $\color{green}+0.00%$	$\color{green}418/418$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

anandkaranubc · 2025-12-30T19:42:18Z

lib/node_modules/@stdlib/blas/ext/base/dsortnans/lib/dsortnans.js

+*
+* ## Notes
+*
+* -   The algorithm is not stable, meaning that the relative order of non-NaN elements is not guaranteed to be preserved.


Suggested change

* - The algorithm is not stable, meaning that the relative order of non-NaN elements is not guaranteed to be preserved.

* - The algorithm is not stable, meaning that the relative order of non-NaN elements is not guaranteed to be preserved.

If we are using this for dquicksort, the "instability" doesn't cause an issue. We can also add something like dsortnans2 (if needed) later which would preserve the relative order of non-NaN elements.

anandkaranubc · 2025-12-30T19:45:57Z

lib/node_modules/@stdlib/blas/ext/base/dsortnans/docs/repl.txt

+
+    If `N <= 0` or `order == 0`, the function returns `x` unchanged.
+
+    A positive order places `NaN` values at the end of the array, while a


In this whole PR, I changed the wording from “increasing order” to “positive order.” The main reason is that we are not actually performing a sort here, and “increasing” or “decreasing” implies that some kind of sorting is taking place.

Same applies for “decreasing order” to “negative order”.

anandkaranubc · 2025-12-30T19:48:18Z

lib/node_modules/@stdlib/blas/ext/base/dsortnans/README.md

+## Notes
+
+-   If `N <= 0` or `order == 0.0`, both functions return `x` unchanged.
+-   A positive order places `NaN` values at the end of the array, while a negative order places `NaN` values at the beginning.


Any explicit need to mention that (the point regarding positive/negative order)?

anandkaranubc · 2025-12-30T19:49:53Z

lib/node_modules/@stdlib/blas/ext/base/dsortnans/examples/index.js

+x = new Float64Array( 10 );
+for ( i = 0; i < x.length; i++ ) {
+	if ( randu() < 0.3 ) {
+		x[ i ] = NaN;
+	} else {
+		x[ i ] = (randu()*20.0) - 10.0;
+	}
+}
+console.log( x );


Is this kind of array generation and population okay? I wanted to inject NaNs into the array, and I couldn’t find a better way to do it.

anandkaranubc · 2025-12-30T19:54:26Z

I have not yet added the C/JS benchmarks because I need some suggestions here. Since no actual “sorting” is being done, I was thinking that we would only need benchmark.js, benchmark.native.js, benchmark.ndarray.js, and benchmark.ndarray.native.js. If this is correct, what would their structure and benchmarking code look like? Could you please share a sample code snippet? Also, how should the isnan checks be handled or adapted in this context?

cc: @kgryte

anandkaranubc · 2025-12-30T19:56:45Z

lib/node_modules/@stdlib/blas/ext/base/dsortnans/lib/dsortnans.js

+// MAIN //
+
+/**
+* Partitions a double-precision floating-point strided array by moving all NaNs either to the beginning or the end of the array.


Function description ok?

anandkaranubc · 2026-01-05T08:10:27Z

@kgryte Sorry for the ping, but whenever you get some time, could you please take a look at this PR? Thank you!

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 30, 2025

anandkaranubc commented Dec 30, 2025

View reviewed changes

anandkaranubc added JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. labels Dec 30, 2025

anandkaranubc requested a review from kgryte December 30, 2025 19:54

anandkaranubc commented Dec 30, 2025

View reviewed changes

Merge branch 'develop' into feat/dsortnans

d633d55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat: add `blas/ext/base/dsortnans`#9445

feat: add `blas/ext/base/dsortnans`#9445
anandkaranubc wants to merge 2 commits intostdlib-js:developfrom
anandkaranubc:feat/dsortnans

anandkaranubc commented Dec 30, 2025

Uh oh!

anandkaranubc Dec 30, 2025

Uh oh!

stdlib-bot commented Dec 30, 2025 •

edited

Loading

Uh oh!

anandkaranubc Dec 30, 2025

Uh oh!

anandkaranubc Dec 30, 2025 •

edited

Loading

Uh oh!

anandkaranubc Dec 30, 2025 •

edited

Loading

Uh oh!

anandkaranubc Dec 30, 2025

Uh oh!

anandkaranubc commented Dec 30, 2025

Uh oh!

anandkaranubc Dec 30, 2025

Uh oh!

anandkaranubc commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	* @param {number} order - NaN placement order
	* @param {number} order - NaN placement order

	* - The algorithm is not stable, meaning that the relative order of non-NaN elements is not guaranteed to be preserved.
	* - The algorithm is not stable, meaning that the relative order of non-NaN elements is not guaranteed to be preserved.


		If `N <= 0` or `order == 0`, the function returns `x` unchanged.

		A positive order places `NaN` values at the end of the array, while a

Uh oh!

Comments

Conversation

anandkaranubc commented Dec 30, 2025

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

anandkaranubc Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Dec 30, 2025

Uh oh!

anandkaranubc Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stdlib-bot commented Dec 30, 2025 •

edited

Loading

anandkaranubc Dec 30, 2025 •

edited

Loading

anandkaranubc Dec 30, 2025 •

edited

Loading