Skip to content

Comments

docs: replace manual for loop in examples#9455

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
hrshya:docs/sr
Dec 31, 2025
Merged

docs: replace manual for loop in examples#9455
Planeshifter merged 1 commit intostdlib-js:developfrom
hrshya:docs/sr

Conversation

@hrshya
Copy link
Contributor

@hrshya hrshya commented Dec 31, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • replaces manual for loop in examples for stats/base/dists/studentized-range/* packages.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 31, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/studentized-range/cdf $\color{red}649/709$
$\color{green}+91.54%$
$\color{red}68/85$
$\color{green}+80.00%$
$\color{green}9/9$
$\color{green}+100.00%$
$\color{red}649/709$
$\color{green}+91.54%$
stats/base/dists/studentized-range/quantile $\color{red}546/580$
$\color{green}+94.14%$
$\color{red}64/80$
$\color{green}+80.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{red}546/580$
$\color{green}+94.14%$

The above coverage report was generated for the changes in this PR.

@hrshya hrshya added the Documentation Improvements, additions, or changes to documentation. label Dec 31, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (CI failure is due to timeout)

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 31, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 31, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

docs: replace manual `for` loop in examples

PR-URL: https://github.com/stdlib-js/stdlib/pull/9455

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 4d332d8 into stdlib-js:develop Dec 31, 2025
83 of 85 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Dec 31, 2025
@kgryte
Copy link
Member

kgryte commented Dec 31, 2025

@Planeshifter What is the reason for the CI timeouts? We are updating dists examples for two files, so getting the timeouts is a bit odd.

@kgryte
Copy link
Member

kgryte commented Dec 31, 2025

@Planeshifter One of the workflows above was canceled after running for 6 hours.

@kgryte
Copy link
Member

kgryte commented Dec 31, 2025

@Planeshifter Looking at the implementation for quantile, it looks like we are hitting an infinite loop.

@kgryte
Copy link
Member

kgryte commented Dec 31, 2025

I am able to reproduce the timeout locally when running the Markdown examples:

make markdown-examples-javascript MARKDOWN_FILTER=".*/stats/base/dists/studentized-range/.*"

@kgryte
Copy link
Member

kgryte commented Dec 31, 2025

Okay. I found the bug.

@Planeshifter
Copy link
Member

Planeshifter commented Dec 31, 2025

@kgryte factory example is incorrectly called with only one argument. Are you pushing a fix?

@kgryte
Copy link
Member

kgryte commented Dec 31, 2025

Yes. In general, this package has a number of issues.

@hrshya hrshya deleted the docs/sr branch January 1, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements, additions, or changes to documentation. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants