feat: add ndarray/base/ternary-loop-interchange-order#9499
feat: add ndarray/base/ternary-loop-interchange-order#9499kgryte merged 3 commits intostdlib-js:developfrom
ndarray/base/ternary-loop-interchange-order#9499Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/ndarray/base/ternary-loop-interchange-order/benchmark/benchmark.js
Show resolved
Hide resolved
lib/node_modules/@stdlib/ndarray/base/ternary-loop-interchange-order/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/ndarray/base/ternary-loop-interchange-order/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
Overall, this looks okay. What I will say is that it is a bit odd to have w as the first array argument. That isn't the practice anywhere else in the codebase. Consider: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/array/base/quaternary2d
And given that we have been consistent with using x as the first array argument for unary and binary, it seems off to then make x the second array argument.
This also applies to ternary-tiling-block-size, where I had similar qualms.
|
Same thing in Lastly, we typically do I will go ahead and merge this and fix this up on my end. But for the future, please do a bit of R&D beforehand to see what the common conventions are elsewhere in the project. |
Resolves stdlib-js/metr-issue-tracker#150.
Description
This pull request:
ndarray/base/ternary-loop-interchange-orderRelated Issues
This pull request has the following related issues:
ndarray/base/ternary-loop-interchange-ordermetr-issue-tracker#150Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers