feat: add C APIs for half-precision floating-point number utilities#9515
feat: add C APIs for half-precision floating-point number utilities#9515gururaj1512 wants to merge 2 commits intostdlib-js:developfrom
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
left a comment
There was a problem hiding this comment.
In general, you added far too many files what what was needed. Namely, a means to expose C APIs.
It is fine to add namespace files, but you took the direction of napi too literally. This namespace should be a mash-up of number/float64 with a couple of additional files (namely, include/* and manifest.json.
kgryte
left a comment
There was a problem hiding this comment.
In general, you added far too many files what what was needed. Namely, a means to expose C APIs.
It is fine to add namespace files, but you took the direction of napi too literally. This namespace should be a mash-up of number/float64 with a couple of additional files (namely, include/* and manifest.json.
Got it... |
|
Needs |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves None
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers