Skip to content

Comments

chore: add structured package data for number/float32/base/exponent#9561

Closed
Lokeshranjan8 wants to merge 1 commit intostdlib-js:developfrom
Lokeshranjan8:float32-json-expo
Closed

chore: add structured package data for number/float32/base/exponent#9561
Lokeshranjan8 wants to merge 1 commit intostdlib-js:developfrom
Lokeshranjan8:float32-json-expo

Conversation

@Lokeshranjan8
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds structured package data for number/float32/base/exponent

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 5, 2026
@Lokeshranjan8 Lokeshranjan8 changed the title chore: add structured package data for number/float32/base/exponent chore: add structured package data for number/float32/base/exponent Jan 5, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
number/float32/base/exponent $\color{green}202/202$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}202/202$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Member

Why does exponent require scaffolding? Ideally, for binary (2-arg) scalar kernel math APIs, we need to add structured package data.
Exponent in operates on unary argument.

@Lokeshranjan8
Copy link
Contributor Author

@Neerajpathak07 Got it, thanks for clarifying.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 5, 2026
@kgryte
Copy link
Member

kgryte commented Jan 5, 2026

@Neerajpathak07 Adding structured package data for unary packages is fine. The question to ask when determining whether to add such metadata is whether we want a ufunc which wraps a respective scalar kernel. If the answer is yes, we want structured data.

In this case, yes, we can add structured data, but the changes in this PR were not correct, as data was written as if for a binary API, not a unary API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants