feat: add Wald distribution variance package #9730

manit2004 · 2026-01-13T15:33:09Z

Progresses #209 .

Description

What is the purpose of this pull request?

This is a WIP pull request. Currently the core functionalities of Wald Distribution variance package has been implemented. Feedback needed on this implementation.

Tests, docs, examples and benchmark is yet to added, pending approval of the core implementation.

Related Issues

Does this pull request have any related issues?

None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

Planeshifter · 2026-01-13T18:00:12Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/src/main.c

+		stdlib_base_is_nan( mu ) ||
+		stdlib_base_is_nan( lambda ) ||
+		lambda <= 0.0 ||
+	mu <= 0.0


This line is missing an indentation level - it should have two tabs to match the other conditions above it.

Suggested change

mu <= 0.0

mu <= 0.0

Planeshifter

Thanks!

First thing I noticed is that README.md is missing and should be added.

stdlib-bot · 2026-01-18T16:19:33Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/wald/variance	$\color{green}176/176$ $\color{green}+0.00%$	$\color{green}10/10$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{green}176/176$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

manit2004 · 2026-01-18T23:02:59Z

@Planeshifter variance package has been implemented fully. Please take a look.

Neerajpathak07

@manit2004 Thanks for this!! Left out a few comments

Neerajpathak07 · 2026-01-22T15:35:31Z

lib/node_modules/@stdlib/stats/base/dists/normal/variance/benchmark/c/Makefile

 #/
 # @license Apache-2.0
 #
-# Copyright (c) 2025 The Stdlib Authors.


Let's revert this.
Normally while adding a new package we avoid making changes to the upstream packages.

Neerajpathak07 · 2026-01-22T15:36:08Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/benchmark/benchmark.js

+	opts = {
+		'dtype': 'float64'
+	};
+	mu = uniform( 100, EPS, 100.0, opts );
+	lambda = uniform( 100, EPS, 20.0, opts );


Suggested change

opts = {

'dtype': 'float64'

};

mu = uniform( 100, EPS, 100.0, opts );

lambda = uniform( 100, EPS, 20.0, opts );

len = 100;

mu = uniform( len, EPS, 100.0 );

lambda = uniform( len, EPS, 20.0 );

Neerajpathak07 · 2026-01-22T15:36:32Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/benchmark/benchmark.js

+
+	b.tic();
+	for ( i = 0; i < b.iterations; i++ ) {
+		y = variance( mu[ i % 100 ], lambda[ i % 100 ] );


Suggested change

y = variance( mu[ i % 100 ], lambda[ i % 100 ] );

y = variance( mu[ i%len ], lambda[ i%len ] );

Neerajpathak07 · 2026-01-22T15:36:42Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/benchmark/benchmark.native.js

+		'dtype': 'float64'
+	};
+	mu = uniform( 100, EPS, 100.0, arrayOpts );
+	lambda = uniform( 100, EPS, 20.0, arrayOpts );


same comment

Neerajpathak07 · 2026-01-22T15:37:01Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/benchmark/c/benchmark.c

+	double elapsed;
+	double lambda[ 100 ];
+	double mu[ 100 ];


Suggested change

double elapsed;

double lambda[ 100 ];

double mu[ 100 ];

double lambda[ 100 ];

double mu[ 100 ];

double elapsed;

order by length

Neerajpathak07 · 2026-01-22T15:37:23Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/benchmark/c/benchmark.c

+
+	t = tic();
+	for ( i = 0; i < ITERATIONS; i++ ) {
+		y = stdlib_base_dists_wald_variance( mu[ i % 100 ], lambda[ i % 100 ] );


Suggested change

y = stdlib_base_dists_wald_variance( mu[ i % 100 ], lambda[ i % 100 ] );

y = stdlib_base_dists_wald_variance( mu[ i%100 ], lambda[ i%100 ] );

Neerajpathak07 · 2026-01-22T15:37:31Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/docs/repl.txt

+    μ: number
+        Location parameter.


I'm confused since mu represents mean but here it is described it as Location parameter. Mind updating this?

Neerajpathak07 · 2026-01-22T15:37:41Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/examples/c/example.c

+		mu = random_uniform( 0.1, 10.0 );
+		lambda = random_uniform( 0.1, 20.0 );


Lets update the examples with STDLIB_CONSTANT_FLOAT64_EPS as well.

Neerajpathak07 · 2026-01-22T15:38:01Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/lib/main.js

+	) {
+		return NaN;
+	}
+	return (mu*mu*mu) / lambda;


Suggested change

return (mu*mu*mu) / lambda;

return ( mu * mu * mu ) / lambda;

Neerajpathak07 · 2026-01-22T15:42:32Z

lib/node_modules/@stdlib/stats/base/dists/wald/variance/README.md

+```
+
+<!-- <div class="equation" align="center" data-raw-text="\operatorname{Var}\left[ X \right] = \frac{\mu^{3}}{\lambda}" data-equation="eq:wald_variance">
+    <img src="https://cdn.jsdelivr.net/gh/stdlib-js/stdlib@51534079fef45e990850102147e8945fb023d1d0/lib/node_modules/@stdlib/stats/base/dists/wald/variance/docs/img/equation_wald_variance.svg" alt="Variance for a Wald distribution.">


Better to remove this link since you haven't added the svg file for wald/variance

manit2004 · 2026-01-22T18:30:49Z

@Neerajpathak07 suggestions have been implemented

manit2004 added 2 commits January 7, 2026 12:16

incomplete main.js

e844e7a

feat: add Wald distribution variance core

e0c7dc8

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 13, 2026

manit2004 mentioned this pull request Jan 13, 2026

Office Hours (2026-01-13) stdlib-js/meetings#72

Closed

Planeshifter self-requested a review January 13, 2026 17:53

Planeshifter reviewed Jan 13, 2026

View reviewed changes

Planeshifter requested changes Jan 13, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 13, 2026

tests & README added, indentation fixed

1f0e83d

errors fixed

d7f6bc9

manit2004 requested a review from Planeshifter January 18, 2026 16:44

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 18, 2026

manit2004 added 4 commits January 19, 2026 02:32

benchmark added

13a67c6

errors fixed

9bf59a5

docs & examples added

0c33518

copyright year fixed

b4dd3f2

manit2004 mentioned this pull request Jan 20, 2026

Office Hours (2026-01-20) stdlib-js/meetings#74

Closed

Neerajpathak07 suggested changes Jan 22, 2026

View reviewed changes

manit2004 added 2 commits January 22, 2026 23:44

all requested changes resolved

9987a19

unused var removed and decalred len

f1ff737

manit2004 requested a review from Neerajpathak07 January 22, 2026 18:30

	y = variance( mu[ i % 100 ], lambda[ i % 100 ] );
	y = variance( mu[ i%len ], lambda[ i%len ] );

	y = stdlib_base_dists_wald_variance( mu[ i % 100 ], lambda[ i % 100 ] );
	y = stdlib_base_dists_wald_variance( mu[ i%100 ], lambda[ i%100 ] );

		mu = random_uniform( 0.1, 10.0 );
		lambda = random_uniform( 0.1, 20.0 );

	return (mumumu) / lambda;
	return ( mu * mu * mu ) / lambda;

Uh oh!

feat: add Wald distribution variance package #9730

Are you sure you want to change the base?

feat: add Wald distribution variance package #9730

Conversation

manit2004 commented Jan 13, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

manit2004 commented Jan 18, 2026

Uh oh!

Neerajpathak07 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manit2004 commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stdlib-bot commented Jan 18, 2026 •

edited

Loading