Skip to content

Conversation

@AyushiJain18270
Copy link
Contributor

Resolves #{ a part of #9329}

Description

What is the purpose of this pull request?

This pull request:

Examples use ndarray instances directly
Outdated helper utilities like ndarray2array are no longer used
The examples match current stdlib ndarray usage patterns
Code shown in docs runs correctly with the current ndarray API

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

N/A


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jan 13, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/ndarray/ddot $\color{green}108/108$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}108/108$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. and removed Needs Review A pull request which needs code review. labels Jan 14, 2026
@kgryte kgryte changed the title docs: improve doctests for ndarray instances in ndarray/ddot docs: improve doctests for ndarray instances in blas/base/ndarray/ddot Jan 14, 2026
@kgryte
Copy link
Member

kgryte commented Jan 14, 2026

@AyushiJain18270 Thank you for your PR; however, the proposed changes are not desired. We are interested in cases where we need to update // returns annotations. The examples that you changed don't have returns annotations (i.e., doctesting) and the use of ndarray2array is intentional, as those examples are intended to be run and print the contents of ndarrays to stdout. As such, I'll go ahead and close this PR.

Thanks again for your interest in stdlib, and we look forward to your future contributions!

@kgryte kgryte closed this Jan 14, 2026
@kgryte kgryte added the Invalid Invalid question, issue, or pull request. label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Documentation Improvements, additions, or changes to documentation. Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants