bench: update random value generation#9925
Merged
kgryte merged 3 commits intostdlib-js:developfrom Jan 29, 2026
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
kgryte
reviewed
Jan 28, 2026
| }); | ||
|
|
||
| bench( pkg+':entropy', function benchmark( b ) { | ||
| bench( format( '%s::entropy', pkg ), function benchmark( b ) { |
Member
There was a problem hiding this comment.
Suggested change
| bench( format( '%s::entropy', pkg ), function benchmark( b ) { | |
| bench( format( '%s:entropy', pkg ), function benchmark( b ) { |
This isn't correct. When benchmarking direct property access, you should only use a single colon.
kgryte
reviewed
Jan 28, 2026
| }); | ||
|
|
||
| bench( pkg+':kurtosis', function benchmark( b ) { | ||
| bench( format( '%s::kurtosis', pkg ), function benchmark( b ) { |
Member
There was a problem hiding this comment.
Same comment. Applies here and elsewhere in this file.
kgryte
requested changes
Jan 28, 2026
Member
kgryte
left a comment
There was a problem hiding this comment.
Apart from the benchmark naming comments, this is looking good.
Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves none .
Description
This pull request:
stats/base/dists/t/*packages.uniform()from@stdlib/random/array/uniformfor cleaner and more consistent code.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers