This repository was archived by the owner on Oct 14, 2025. It is now read-only.
Enable use_cache = FALSE for get_metadata()#117
Open
krlong68 wants to merge 6 commits intostemangiola:masterfrom
Open
Enable use_cache = FALSE for get_metadata()#117krlong68 wants to merge 6 commits intostemangiola:masterfrom
krlong68 wants to merge 6 commits intostemangiola:masterfrom
Conversation
multimeric
reviewed
Oct 17, 2023
Collaborator
multimeric
left a comment
multimeric
left a comment
There was a problem hiding this comment.
Thanks for the PR! I'll fix up the CI issues in another PR.
Collaborator
|
Can you please also pull from master, cheers. |
Owner
|
Hello All, sorry all for the silence. The API evolved quite a bit. What should we do about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE: metadata.R/
get_metadata(use_cache = FALSE)was still using the cached file due to multipleif (!file.exists())bypassesADJUSTED:
sync_remote_file()adjusted to get user permission to overwrite if cached file existsget_metadata()adjusted to push allfile.exists()checking to utils.R/sync_remote_file()