Refactoring: Fix sonarQube issues in JSONObject#1005
Conversation
|
| return false; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add JavaDocs for this method
| return true; | ||
| } | ||
|
|
||
| private boolean checkThis(Object valueThis, Object valueOther) { |
There was a problem hiding this comment.
Please add JavaDocs for this method
| public void issue743SerializationMapWith1000Objects() { | ||
| HashMap<String, Object> map = buildNestedMap(1000); | ||
| JSONParserConfiguration parserConfiguration = new JSONParserConfiguration().withMaxNestingDepth(1000); | ||
| HashMap<String, Object> map = buildNestedMap(500); |
There was a problem hiding this comment.
Please add a comment explaining why the limit was changed. Also, method signature should be updated to '500Objects'.
Not why this testcase started failing in laptop tests.
|
What problem does this code solve? Does the code still compile with Java6? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status Starting 3-day comment window. @marilynel Please fix the JavaDoc comments, if you get a chance before merge. Otherwise, they can be included in the next batch of SonarQube fixes. Also, not sure why SonarQube is reporting a new issue for code that hasn't changed in more than a decade. Will address it with the rest of the issues. |
stleary
changed the title
2 participants
No description provided.