Refactoring: String check logic in CDL

[Md-Yasir]

changed string checking logic

string.length() > 0 to !string.isEmployee

Issue

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stleary]

The code looks good. If you decide to make more updates, consider grouping multiple small changes into a single review. For most, you can get an idea about how to make the change by checking previous pull requests. But certain issues, like refactoring a method to reduce the complexity, will need to be done in a way that does not introduce new problems. The refactoring issues should be handled one at a time.

[stleary]

No formal PR for this one-line simple change.

[Md-Yasir]

The code looks good. If you decide to make more updates, consider grouping multiple small changes into a single review. For most, you can get an idea about how to make the change by checking previous pull requests. But certain issues, like refactoring a method to reduce the complexity, will need to be done in a way that does not introduce new problems. The refactoring issues should be handled one at a time.

Roger that..

No formal PR for this one-line simple change.

Just a try since this is my first time...These updates will flow to sonarqube automatically right?

[stleary]

Yes, the sonarqube build occurs when the PR is first posted. You can see the entry above, which was built yesterday.