Refactoring: Fix some SonarQube issues#1017
Conversation
src/main/java/org/json/Cookie.java
Outdated
| * @return The unescaped string. | ||
| */ | ||
| public static String unescape(String string) { | ||
| int i = 0; |
There was a problem hiding this comment.
Please add a link in the description to the SonarQube issue you are fixing here.
There was a problem hiding this comment.
Please provide a reason, or revert this change. There does not appear to be an associated SonarQube issue.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks, I missed that. The index is still being updated within the loop. Also, I have marked the issue as 'Accepted', so it does not need to be fixed. Please revert this change.
|
|
What problem does this code solve? Does the code still compile with Java6? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status Starting 3-day comment window |
stleary
added
Approved - 3-day window
and removed
In review
Code review action items
labels
2 participants
Commit 1
Commit 2
Commit 3
Commit 4