Merged
Conversation
This was referenced Jan 11, 2025
Closed
Owner
|
@Simulant87 Please remove JSONArray, JSONObject, and JSONTokener as these have been merged in #937. The new unit tests may be kept. |
This reverts commit afd9a6f.
Contributor
Author
|
I updated the branch, and it only contains missing JavaDoc and the new test cases now. |
Owner
|
What problem does this code solve? Does the code still compile with Java6? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status |
stleary
approved these changes
Jan 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken the changes from #937 preserving an attribution history of the authors commits:
In addition:
New unit tests for Strict mode using JSONTokener and JSONParserConfiguration #934
Bugfix: NullPointerException thrown for invalid input on JSONTokener without strict mode #936
this can be taken as a discussion baseline, or merged instead or after #937 and makes #934 and #936 obsolete