Refactoring: Remove unused code

[AlexCai2019]

I found these 2 can be optimized during the last refactor.

• Remove NULL.equals(object) in warp() method on line 2756 of JSONObject.java since line 2752 has already tested it.
• Remove the empty string in readByIndexToken() method on line 249 of JSONPointer.java.

[javadev]

formatting

[stleary]

@AlexCai2019 Please make this formatting change.

[AlexCai2019]

how should I do that?

[javadev]

if (    object instanceof JSONObject || object instanceof JSONArray
     || object instanceof JSONString || object instanceof Byte
     || object instanceof Character || object instanceof Short
     || object instanceof Integer   || object instanceof Long
     || object instanceof Boolean   || object instanceof Float
     || object instanceof Double    || object instanceof String
     || object instanceof BigInteger|| object instanceof BigDecimal
     || object instanceof Enum) {

    return object;
}

[stleary]

how should I do that?

Just have 2 checks per line, so split line 2755 into 2 lines

[stleary]

What problem does this code solve?
Removes an unneeded check for null in JSONObject.wrap()

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
JSONPointer readByIndexToken() had a trivial change

Review status
APPROVED

Starting 3-day comment window

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud