Allow users to extend JSONObject with custom map#998
Closed
spaffrath wants to merge 4 commits intostleary:masterfrom
Closed
Allow users to extend JSONObject with custom map#998spaffrath wants to merge 4 commits intostleary:masterfrom
spaffrath wants to merge 4 commits intostleary:masterfrom
Conversation
|
Owner
|
Sorry, appreciate the effort, but this change should be done in a forked repository. It can't be accepted for this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Issue #822. I know this has been a frequently discussed issue and I agree with the sentiment of keeping the repo as a reference implementation of the JSON spec. Allowing the map initialization to be overridden makes no functional changes to the repo at all but allows users the flexibility to extend the implementation to provide whatever ordering they may desire, be it FIFO, alphabetical, or whatever else may be needed.
Thank you for your consideration.