fix: make install error on ROCm #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stotko
requested changes
Jan 19, 2026
Owner
stotko
left a comment
stotko
left a comment
There was a problem hiding this comment.
Thanks for the fix! Could you address the two (minor) comments I've left, before this gets merged?
src/stdgpu/CMakeLists.txt
Outdated
| install(FILES "${stdgpu_SOURCE_DIR}/cmake/${STDGPU_BACKEND_DIRECTORY}/determine_thrust_paths.cmake" | ||
| DESTINATION "${STDGPU_CMAKE_INSTALL_DIR}/${STDGPU_BACKEND_DIRECTORY}" | ||
| COMPONENT stdgpu) | ||
| if(STDGPU_BACKEND STREQUAL STDGPU_BACKEND_CUDA) |
Owner
There was a problem hiding this comment.
Suggested change
| if(STDGPU_BACKEND STREQUAL STDGPU_BACKEND_CUDA) | |
| if(NOT STDGPU_BACKEND STREQUAL STDGPU_BACKEND_HIP) |
Owner
There was a problem hiding this comment.
The OpenMP backend also makes use of determine_thrust_paths.cmake, so it's better to check for HIP rather than for CUDA.
src/stdgpu/CMakeLists.txt
Outdated
| install(FILES "${stdgpu_SOURCE_DIR}/cmake/${STDGPU_BACKEND_DIRECTORY}/determine_thrust_paths.cmake" | ||
| DESTINATION "${STDGPU_CMAKE_INSTALL_DIR}/${STDGPU_BACKEND_DIRECTORY}" | ||
| COMPONENT stdgpu) | ||
| endif() |
Owner
There was a problem hiding this comment.
Add a newline at the end of the file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 96.64% 96.75% +0.11%
==========================================
Files 33 33
Lines 2622 2622
==========================================
+ Hits 2534 2537 +3
+ Misses 88 85 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix make install error on ROCm because
hip/determine_thrust_paths.cmakenot exist.The snapshot with error show as below:
