Add Timestamp to BaseTelegram and clean up TelegramParser#20
Closed
Muralidaran-22 wants to merge 1 commit intostprograms:mainfrom
Closed
Add Timestamp to BaseTelegram and clean up TelegramParser#20Muralidaran-22 wants to merge 1 commit intostprograms:mainfrom
Muralidaran-22 wants to merge 1 commit intostprograms:mainfrom
Conversation
Added a Timestamp property to the BaseTelegram class to store the creation or processing time of the telegram. Updated the TelegramArgs constructor in TelegramParser.cs to set this Timestamp to the current date and time (DateTime.Now) when a new TelegramArgs instance is created. Removed an unnecessary space in the TelegramParser class before the type check for the telegram.
stprograms
reviewed
Mar 8, 2025
Owner
stprograms
left a comment
stprograms
left a comment
There was a problem hiding this comment.
First of all, thank you very much for your interest and contribution to the project. 😃
What do you think about having the Timestamp as a readonly property, which is set in the constructor of the BaseTelegram itself? I think this is better than setting it when an event is triggered.
Owner
|
Since I did some changes in parallel to your submission which now led to conflicts in the file, I have implemented the TimeStamp in the BaseTelegram myself, including corresponding unit tests (see #28 ). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Timestamp property to the BaseTelegram class to store the creation or processing time of the telegram. Updated the TelegramArgs constructor in TelegramParser.cs to set this Timestamp to the current date and time (DateTime.Now) when a new TelegramArgs instance is created. Removed an unnecessary space in the TelegramParser class before the type check for the telegram.