Add parallel reading support to S3SessionManager.list_messages() #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add max_parallel_reads parameter to S3SessionManager.__init__() - Implement parallel S3 reads using ThreadPoolExecutor in list_messages() - Support both instance-level and per-call max_parallel_reads configuration - Add comprehensive tests for parallel reading functionality - Maintain backward compatibility (default max_parallel_reads=1)
…r.list_messages()]
JackYPCOnline
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
Note that we did attempt this at one other point, but had to revert: #1013 I think long-term we'd want to support asyncio as well, as otherwise we're forcing threads on folks who just want to use async all the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds parallel reading support to S3SessionManager.list_messages() to improve performance when retrieving multiple messages from S3. The implementation uses ThreadPoolExecutor to fetch messages concurrently, significantly reducing latency for sessions with many messages.
This PR is a revision of #1186
Fix magic number and cumbersome parameters validation.
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.