fix: import errors for models with optional imports #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
pgrayy
reviewed
Dec 22, 2025
| from .writer import WriterModel | ||
|
|
||
| return WriterModel | ||
| raise AttributeError(f"module '{__name__}' has no attribute '{name}'") |
Member
There was a problem hiding this comment.
To match convention, I would recommend instead doing:
raise ImportError(f"cannot import name '{name}' from '{__name__}' ({__file__})")
This is the same error message that would be printed without the __getattr__ override.
pgrayy
reviewed
Dec 22, 2025
| ] | ||
|
|
||
|
|
||
| def __getattr__(name: str): |
Member
There was a problem hiding this comment.
I would recommend setting the return type to -> Any.
pgrayy
reviewed
Dec 22, 2025
|
|
||
| __all__ = ["bedrock", "model", "BedrockModel", "Model"] | ||
| # Type checking imports for static analysis | ||
| if TYPE_CHECKING: |
Member
There was a problem hiding this comment.
Curious, does this help with autocomplete? For example, if in my code editor I start typing from strands.modules import, will it show what is in this list as options?
zastrowm
approved these changes
Dec 22, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing lazy loading in models init.py file
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.